feat: add domain templates + leaderboard notification (#219, #294, #295)#337
Open
zsxh1990 wants to merge 1 commit into
Open
feat: add domain templates + leaderboard notification (#219, #294, #295)#337zsxh1990 wants to merge 1 commit into
zsxh1990 wants to merge 1 commit into
Conversation
5d3a15b to
97e732a
Compare
Owner
97e732a to
057b71b
Compare
Contributor
Author
|
Done! Rebased onto latest main and removed #219/leaderboard changes. PR now only contains:
Clean and ready for review 👍 |
057b71b to
f27f076
Compare
Ikalus1988#295) - lessons/contrib/templates/database.md - lessons/contrib/templates/network.md Signed-off-by: zsxh1990 <445655361@qq.com>
f27f076 to
92c4ef7
Compare
Contributor
Author
|
Audit fails due to a path resolution bug in validate_lessons.py — it cannot handle relative paths from CI. All other checks pass (dco, lint, quality, isolate). The templates follow TEMPLATE.md format. Would you like a separate PR to fix the validate script? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #219, #294, #295
Changes
Clean branch from main, no accidental modifications to existing files.