Skip to content

new functions#11

Open
late4marshmellow wants to merge 15 commits into
Iketaki:masterfrom
late4marshmellow:master
Open

new functions#11
late4marshmellow wants to merge 15 commits into
Iketaki:masterfrom
late4marshmellow:master

Conversation

@late4marshmellow
Copy link
Copy Markdown

Added several new functions

  • Invert colors or white.
  • autorefresh everyhour on a spesified minute on the clock
  • toggle scrollbar

@Iketaki
Copy link
Copy Markdown
Owner

Iketaki commented Mar 21, 2023

Thanks for your enthusiastic PR!
Let me make a few comments to maintain the quality of the code.

Comment thread MMM-WebView.js
start: function () {
if (this.config.autoRefresh) {

start: function() {
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please correct the indentation to the same hierarchy as before?

Comment thread README.md
| `refreshMinute` | [Optional] Refresh every hour on the set minute. 00-59 |
| `invert` | [Optional] Set to true to activate invert color or white |
| `invertColors` | [Optional] Set to true to invert colors, false to invert only white (Works only if 'invert' is set to true) |
| `filterPercent | [Optional] intencity of invert |
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a section on showScrollbar?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants