Skip to content

🛡️ Sentinel: [security improvement] Add fetch timeout to prevent DoS#163

Merged
ImChong merged 1 commit into
mainfrom
sentinel/fix-fetch-timeout-11515097193736564760
Jul 1, 2026
Merged

🛡️ Sentinel: [security improvement] Add fetch timeout to prevent DoS#163
ImChong merged 1 commit into
mainfrom
sentinel/fix-fetch-timeout-11515097193736564760

Conversation

@ImChong

@ImChong ImChong commented Jul 1, 2026

Copy link
Copy Markdown
Owner

🚨 Severity: MEDIUM
💡 Vulnerability: fetch requests inside fetchParkourBundleIosPatchStatus lacked a timeout mechanism. An unresponsive endpoint could cause the promise to hang indefinitely, consuming resources and potentially causing a Denial of Service (DoS).
🎯 Impact: Prevents the application/UI thread from hanging indefinitely due to slow or unresponsive network requests.
🔧 Fix: Introduced an AbortController with a 10-second timeout wrapping the fetch calls. Added a finally block to clear the timeout and prevent memory leaks.
Verification: Verified via manual review and by ensuring the test suite passes (pnpm test ok).


PR created automatically by Jules for task 11515097193736564760 started by @ImChong

- 在 `fetchParkourBundleIosPatchStatus` 中的 `fetch` 请求增加了 `AbortController`,并设置了 10 秒超时。
- 修复了因为缺失超时机制而可能导致的未受控网络请求挂起(DoS)的安全风险。

Co-authored-by: ImChong <74563097+ImChong@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@ImChong ImChong merged commit 0a82629 into main Jul 1, 2026
1 check passed
@ImChong ImChong deleted the sentinel/fix-fetch-timeout-11515097193736564760 branch July 1, 2026 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant