try to overpass int16 restriction on image size#19
Open
AlexeyTrekin wants to merge 1 commit intoImage-Py:masterfrom
Open
try to overpass int16 restriction on image size#19AlexeyTrekin wants to merge 1 commit intoImage-Py:masterfrom
AlexeyTrekin wants to merge 1 commit intoImage-Py:masterfrom
Conversation
Member
|
just using int32, that is for the edge pixels, not very large. and if the image is so large, there would be another question: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current implementation is restricted to padded image size 32767 due to use of int16 for indexing, so I changed it to int32.
Maybe there should be a condition to use int32 only for bigger images? Didn't find out how to determine the size restriction inside this function.