Skip to content

Add test for image shares persisting after collection deletion #1428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danlamanna merged 1 commit into from
Mar 16, 2026
Merged

Add test for image shares persisting after collection deletion #1428

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion isic/core/tests/test_collection_shares.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import pytest

from isic.core.permissions import get_visible_objects
from isic.core.services.collection import collection_share
from isic.core.services.collection import collection_delete, collection_share
from isic.core.services.collection.image import collection_add_images


Expand Down Expand Up @@ -53,3 +53,15 @@ def test_collection_shares_beget_image_shares(staff_user, user, private_collecti

assert user.has_perm("core.view_image", new_private_image)
assert get_visible_objects(user, "core.view_image").count() == 2


@pytest.mark.django_db
def test_collection_deletion_does_not_revoke_image_shares(staff_user, user, private_collection):
private_image = private_collection.images.first()
collection_share(collection=private_collection, grantor=staff_user, grantee=user)
assert user.has_perm("core.view_image", private_image)

collection_delete(collection=private_collection)

assert user.has_perm("core.view_image", private_image)
assert get_visible_objects(user, "core.view_image").count() == 1