Fix memory leak with fonts returned from MagickQueryFonts()#786
Open
ndossche wants to merge 1 commit into
Open
Fix memory leak with fonts returned from MagickQueryFonts()#786ndossche wants to merge 1 commit into
ndossche wants to merge 1 commit into
Conversation
The correct usage is to also free the strings from the array as shown in
`PHP_METHOD(Imagick, queryFonts)`.
ASAN report:
```
Direct leak of 2066 byte(s) in 109 object(s) allocated from:
#0 0x700f9cafe9c7 in malloc ../../../../src/libsanitizer/asan/asan_malloc_linux.cpp:69
Imagick#1 0x700f965ada48 in ConstantString MagickCore/string.c:692
Imagick#2 0x700f965c32b0 in GetTypeList MagickCore/type.c:680
Imagick#3 0x700f96961ce3 in MagickQueryFonts MagickWand/magick-wand.c:716
Imagick#4 0x700f9784d1fe in php_imagick_check_font /work/php-imagemagick/imagick_helpers.c:445
Imagick#5 0x700f9782cc27 in zim_ImagickDraw_setFont /work/php-imagemagick/imagickdraw_class.c:556
Imagick#6 0x61b6d96c9395 in zend_test_execute_internal /work/php-src/ext/zend_test/observer.c:306
Imagick#7 0x61b6d99f08bb in ZEND_DO_FCALL_SPEC_RETVAL_UNUSED_HANDLER /work/php-src/Zend/zend_vm_execute.h:2024
Imagick#8 0x61b6d9b51e07 in execute_ex /work/php-src/Zend/zend_vm_execute.h:116514
Imagick#9 0x61b6d9b66d70 in zend_execute /work/php-src/Zend/zend_vm_execute.h:121962
Imagick#10 0x61b6d9ccb56b in zend_execute_script /work/php-src/Zend/zend.c:1980
Imagick#11 0x61b6d96fdd7b in php_execute_script_ex /work/php-src/main/main.c:2645
Imagick#12 0x61b6d96fe18b in php_execute_script /work/php-src/main/main.c:2685
Imagick#13 0x61b6d9cd10d6 in do_cli /work/php-src/sapi/cli/php_cli.c:951
Imagick#14 0x61b6d9cd36a3 in main /work/php-src/sapi/cli/php_cli.c:1362
Imagick#15 0x700f9bddc1c9 in __libc_start_call_main ../sysdeps/nptl/libc_start_call_main.h:58
Imagick#16 0x700f9bddc28a in __libc_start_main_impl ../csu/libc-start.c:360
Imagick#17 0x61b6d8809df4 in _start (/work/php-src/build-dbg-asan/sapi/cli/php+0x609df4) (BuildId: 97494815ba6ad97379608f28619e331873dc4434)
SUMMARY: AddressSanitizer: 2066 byte(s) leaked in 109 allocation(s).
```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The correct usage is to also free the strings from the array as shown in
PHP_METHOD(Imagick, queryFonts).ASAN report:
Note: this was found by a hybrid static-dynamic analyzer I'm developing.