Make thumbnails optional for add attachment#64
Open
enermark wants to merge 1 commit intoImzachjohnson:mainfrom
Open
Make thumbnails optional for add attachment#64enermark wants to merge 1 commit intoImzachjohnson:mainfrom
enermark wants to merge 1 commit intoImzachjohnson:mainfrom
Conversation
Not all attachments are images. Suggesting thumbs are optional as a result.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not all attachments are images. Suggesting that the 2 thumb values are optional as a result.
Without making the 2 thumbs optional, validation errors are thrown when uploading non-images. It seems like the uploads still succeed, but the upload success message never appears - not sure if other steps are skipped.
Thanks for considering.