12 add variant summary module - #13
Draft
marrip wants to merge 24 commits into
Draft
Conversation
ous_metrics folder in the header is change to metrics to make it more general
…t module call, add channel comments
Adapt metrics module to standard
Omer0191
reviewed
Oct 9, 2025
Collaborator
There was a problem hiding this comment.
should we add a samplesheet from ous as well so we can see the difference and work accordingly?
Collaborator
Author
There was a problem hiding this comment.
I think we can keep specific samplesheets out of the repo and maybe share them "privately" as they will not be part of the final pipeline.
Omer0191
approved these changes
Oct 9, 2025
Collaborator
Author
|
I think this one is still worked on as it is in draft mode. The changes are due to branching of your branch @Omer0191 and targeting the develop branch. We have to wait for Jaime and Jean-Marc to finish their work first |
Closed
marrip
commented
Oct 23, 2025
| # convert gitpod to local user | ||
| RUN groupmod -n ${USERNAME} -g ${USER_GID} gitpod \ | ||
| && usermod -md /home/${USERNAME} -l ${USERNAME} -u ${USER_UID} -s /usr/bin/fish -aG docker gitpod \ | ||
| RUN groupmod -n ${USERNAME} -g ${USER_GID:-1000} gitpod \ |
Collaborator
Author
There was a problem hiding this comment.
what does the :-1000 do?
marrip
force-pushed
the
5-add-metrics_plotting_module
branch
from
November 14, 2025 09:50
b92179d to
fa9f05b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@marrip