Skip to content

12 add variant summary module - #13

Draft
marrip wants to merge 24 commits into
5-add-metrics_plotting_modulefrom
12-add-variant-summary-module
Draft

12 add variant summary module#13
marrip wants to merge 24 commits into
5-add-metrics_plotting_modulefrom
12-add-variant-summary-module

Conversation

@marrip

@marrip marrip commented Oct 8, 2025

Copy link
Copy Markdown
Collaborator

Omer0191 and others added 22 commits September 3, 2025 11:55
ous_metrics folder in the header is change to metrics to make it more general
@marrip
marrip requested review from Omer0191 and tonjegul October 8, 2025 11:31
@marrip marrip added the enhancement New feature or request label Oct 8, 2025
@marrip marrip linked an issue Oct 8, 2025 that may be closed by this pull request
@marrip
marrip changed the base branch from main to develop October 8, 2025 11:32
@marrip
marrip marked this pull request as draft October 8, 2025 11:32

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we add a samplesheet from ous as well so we can see the difference and work accordingly?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can keep specific samplesheets out of the repo and maybe share them "privately" as they will not be part of the final pipeline.

@marrip

marrip commented Oct 9, 2025

Copy link
Copy Markdown
Collaborator Author

I think this one is still worked on as it is in draft mode. The changes are due to branching of your branch @Omer0191 and targeting the develop branch. We have to wait for Jaime and Jean-Marc to finish their work first ☺️

@marrip marrip mentioned this pull request Oct 9, 2025
@marrip
marrip changed the base branch from develop to 5-add-metrics_plotting_module October 16, 2025 08:48
Comment thread .devcontainer/Dockerfile
# convert gitpod to local user
RUN groupmod -n ${USERNAME} -g ${USER_GID} gitpod \
&& usermod -md /home/${USERNAME} -l ${USERNAME} -u ${USER_UID} -s /usr/bin/fish -aG docker gitpod \
RUN groupmod -n ${USERNAME} -g ${USER_GID:-1000} gitpod \

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does the :-1000 do?

@marrip
marrip force-pushed the 5-add-metrics_plotting_module branch from b92179d to fa9f05b Compare November 14, 2025 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add variant summary module

4 participants