7 add small variant list module - #8
Open
marrip wants to merge 4 commits into
Open
Conversation
marrip
requested review from
Omer0191,
danielvo,
gertrudeln,
inful,
jaimicore and
sofievo
August 29, 2025 12:46
marrip
force-pushed
the
7-add-small-variant-list-module
branch
from
August 29, 2025 12:50
67095b7 to
959f8d5
Compare
marrip
marked this pull request as draft
August 29, 2025 12:52
Omer0191
marked this pull request as ready for review
September 2, 2025 08:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey guys,
here is my first draft for the module that should update the small variant vcf list. Our code at HUS might be different from your nodes so we need to discuss if the changes we made would work forall other nodes (I included at least one representative from each node now). I have some very old code from OUS which does not check for control samples and does not remap certain tumor types so please let me know if that is something we don't want a.k.a. only HUS wants.
I guess you might have concerns about where the files are put. For now, let's not focus too much on that. We can change these paths later and create specific profiles for each node.
I also thought that this bash script is a bit clumsy and maybe we want something in python instead doing all of this. I would volunteer to put something together in case we agree to go that route. Also, for me it would make sense to not update but rather recreate the file each time we run this process and just glob all runs' small variant vcf files, remove control samples and remap sample types (if we agree on that), exclude vcfs/samples/patients we don't want (have a blacklist of those somewhere), and finally sort and uniq the list.
Please reach out in case you have questions either on Teams or here. We can also do a meeting if that is easier for you.
Your feedback is highly appreciated 🙂