Harden Gmail delete flow and sort selection handling#92
Open
ZingBing wants to merge 1 commit intoInboxWhiz:mainfrom
Open
Harden Gmail delete flow and sort selection handling#92ZingBing wants to merge 1 commit intoInboxWhiz:mainfrom
ZingBing wants to merge 1 commit intoInboxWhiz:mainfrom
Conversation
Author
|
As an additional note, this PR may also address #82 (the deleting portion, unsubscribe has not been addressed) and #73. I can look into the errors from 73 but this PR changes the way bulk deletes are handled. @anna-st-40 Would you or copilot be able to review this PR? I believe it would help the overall functionality of the extension. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #81
Summary
This PR hardens Gmail delete automation to be safer and more reliable across both normal and bulk delete flows, including Gmail AI sort variations and asynchronous bulk-delete toasts.
What Changed
Delete flow safety and scope control
from:(...)search scope.Sort behavior (
Most recent)_ensureMostRecentFilter()logic:Most recent.Bulk vs non-bulk handling
Select all conversations...bannerdialog/alertdialog,data-mdc-dialog-action="ok").Success detection (toast handling)
Error behavior
Why
Previously there were two opposite failure modes:
This PR keeps strict safety checks while improving practical reliability of user-facing success/error status.
Testing Notes
Manually tested in Gmail:
Select all conversations...): confirm dialog + async toast variant.Most recentvsMost relevant.Notes
package-lock.jsonwas not included in this PR.