Skip to content

chore(ci): harden CI workflows #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
amagan wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

chore(ci): harden CI workflows #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/code-PR_verify-fallback.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,5 +11,6 @@ jobs:
if: "false"
name: Code / Verify
runs-on: ubuntu-24.04
permissions: {}
steps:
- run: echo "No Code / Verify required"
20 changes: 2 additions & 18 deletions .github/workflows/code-npm_node-PR_verify.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,27 +28,11 @@ jobs:
name: Code / Verify
timeout-minutes: 60
runs-on: ubuntu-24.04
permissions:
contents: read
env:
ASDF_BRANCH_VERSION: 0.18.0
steps:
- name: Validate admin permissions
id: permission-check
uses: actions/github-script@f28e40c7f34bde8b3046d885e986cb6290c5673b # v7
with:
script: |
const { data } = await github.rest.repos.getCollaboratorPermissionLevel({
owner: context.repo.owner,
repo: context.repo.repo,
username: context.actor
});

const permission = data.permission;
core.info(`User permission level: ${permission}`);

if (permission !== "admin") {
core.setFailed(`User @${context.actor} is not a repository admin.`);
}

- name: Checkout / Branch Head
uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4
with:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/code-npm_node-publish-release-and-snapshot.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,7 +332,7 @@ jobs:
BASELINE_BRANCH=${{ github.event.inputs.BASELINE || github.ref }}
echo "BASELINE_BRANCH=${BASELINE_BRANCH#refs/heads/}" >> "$GITHUB_ENV"

- uses: actions/create-github-app-token@v3
- uses: actions/create-github-app-token@bcd2ba49218906704ab6c1aa796996da409d3eb1 # v3
id: app-token
with:
client-id: ${{ vars.APP_CLIENT_ID }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/code-npm_node-sonarcloud-analysis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ jobs:

- name: Set up JDK 21 for SonarScanner
if: steps.project.outputs.has-package == 'true'
uses: actions/setup-java@v5
uses: actions/setup-java@b6effb05e454b25005698d916606bdc6ffcbf961 # v5
with:
distribution: temurin
java-version: "21"
Expand Down
10 changes: 10 additions & 0 deletions .github/workflows/code-release_preview.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,9 @@ jobs:
check-changes-in-paths:
name: Check for changes in corresponding paths
runs-on: ubuntu-24.04
permissions:
contents: read
pull-requests: read
if: ${{ github.event.pull_request.draft == false || contains(join(github.event.pull_request.labels.*.name, ', '), 'release-type') || contains(join(github.event.pull_request.labels.*.name, ', '), 'release-preview') }}
outputs:
detected: ${{ steps.changes.outputs.paths }}
Expand All @@ -42,6 +45,9 @@ jobs:
needs: check-changes-in-paths
if: ${{ (contains(join(github.event.pull_request.labels.*.name, ', '), 'release-type') || contains(join(github.event.pull_request.labels.*.name, ', '), 'release-preview')) && needs.check-changes-in-paths.outputs.detected == 'true' }}
runs-on: ubuntu-24.04
permissions:
contents: read
pull-requests: write
steps:
- name: Checkout merge commit
uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4
Expand Down Expand Up @@ -130,6 +136,8 @@ jobs:
needs: check-changes-in-paths
if: ${{ (contains(join(github.event.pull_request.labels.*.name, ', '), 'release-type') || contains(join(github.event.pull_request.labels.*.name, ', '), 'release-preview')) && needs.check-changes-in-paths.outputs.detected == 'false' }}
runs-on: ubuntu-24.04
permissions:
pull-requests: write
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
steps:
Expand All @@ -144,6 +152,8 @@ jobs:
needs: check-changes-in-paths
if: ${{ !contains(join(github.event.pull_request.labels.*.name, ', '), 'release-type') && needs.check-changes-in-paths.outputs.detected == 'true' && github.event.pull_request.draft == false && vars.DEVELOPMENT_FLOW != 'trunk-based-development' }}
runs-on: ubuntu-24.04
permissions:
pull-requests: write
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
steps:
Expand Down
Loading