feat(youtube): SABR extractor support#69
Conversation
|
bit of context since this isn't a fresh idea: the PoC #68 (and the client PoC InfinityLoop1308/PipePipeClient#43) were exactly that, throwaway PoCs to prove SABR actually plays end to end. they did their job, so i closed #68 rather than keep pushing onto a messy branch. this is the real integration, rebuilt clean. the SABR extractor stands on its own here, and i reworked the buffering to be reader-driven (pacing + cache eviction follow what the player has actually read, not the play head, so it doesn't deadlock or blow up memory anymore), plus the Safari client-version fix and the live-metadata foundation. on the client side i split it too: the media3 migration is its own PR (InfinityLoop1308/PipePipeClient#45) and the SABR client sits on top. still WIP, not for merge yet (FORCE_SABR_FOR_TESTING is on so every video goes through SABR while i hammer it), but this is where it continues from now :) |
7bab69f to
9364aa7
Compare
9364aa7 to
12ec2e6
Compare
|
I've been working on this whenever I had some free time. I tested it a lot (u know me by now, im a little paranoid 🥲) on a S25, a Z Fold 5 and a Pixel 8, mostly the app/code itself, and found and fixed a shit load of bugs along the way 🫠: forward seeks, rewind after the stream buffered to the end, return from background, a crash on decoder init... u can see it all in the commit history. Honestly I'm starting to reach my limits testing alone, so I think this is getting close to review-ready @InfinityLoop1308. No rush at all, as we say in French: y a pas le feu au lac :) If u want me to split this PR differently (or anything else really), don't hesitate to tell me. One thing I'd really like your take on: how we wire SABR into the app. My take is it shouldn't be SABR-only, I'd rather marry both, keep the current delivery and have SABR live next to it (as an option / fallback) so we don't regress anyone. But u might see it differently, so im genuinely curious what u think. Right now Last thing: it's pushed with Could be handy to hand a debug build to users who hit issues so their reports are actually useful. |
|
Oh and I almost forgot the fun part 😄 I wrote actual docs for the extractor! the whole thing's in there: architecture, extraction flow, the info model, the downloader, paging, adding a service, the YouTube service... and then it dives deep into SABR (UMP framing, part-type decoding, building the had a real blast writing it, curious what u think :) (If u have time of course) |
First real integration of the SABR extractor (supersedes the PoC #68). Pairs with the client SABR PR (coming) and the media3 migration InfinityLoop1308/PipePipeClient#45. Tracking: InfinityLoop1308/PipePipeClient#42.
Docs (how SABR works end to end): https://priveetee.github.io/Docs-PipePipe/developer-guide/introduction
Related:
Summary
Adds the YouTube SABR (Server ABR) extraction path end to end: UMP wire reading, the proto request/response codecs, the typed UMP parts (media, policy, context, onesie...), response decoding + mp4/webm segment index parsing, and the session/state model the client pump drives. A new
DeliveryMethod.SABRexposes it.Changes
DeliveryMethod.SABRdelivery method.YoutubeStreamExtractor.rewindBufferedTo/prepareForRewind): the buffered head was one-way (assumeBufferedUntilonly ever extends), so a rewind onto an already-sent segment left the request claiming we still had it and the server sent nothing back; this shrinks the head (contiguous + observed-timing) so the server re-sends from the target.SabrLiveMetadatagetters (live foundation).YoutubeParsingHelper: Safari player request now uses the live web client version (the hardcoded one started returningpage needs to be reloaded).Why
YouTube serves some videos SABR-only; the old paths return "Content Not Yet Supported". This adds a real extractor path, with the client PR as the runnable counterpart.
Impact / Compatibility
The new
sabr/package andDeliveryMethod.SABRare additive. The one behavioural change is inYoutubeStreamExtractor: aFORCE_SABR_FOR_TESTINGflag (currentlytrue) routes every YouTube video through the SABR pipeline, so HLS/DASH/progressive are bypassed on purpose to stress-test SABR on everything. With the flagfalse(production default), HLS/DASH stay untouched and SABR only fills the SABR-only / no-HLS gap that upstream currently throwsContentNotSupportedExceptionon. The Safari client-version fix also helps the existing logged-in path.Validation
./gradlew :extractor:compileJava -x checkstyleMainNotes
FORCE_SABR_FOR_TESTING = trueon purpose: all YouTube playback goes through SABR with no HLS fallback, so we exercise the SABR path on every video. It flips back tofalsebefore merge (then HLS stays as fallback and SABR only covers the SABR-only gap).checkstyleMainexcluded, fails repo-wide unrelated to this change.