Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #23 +/- ##
=============================================
- Coverage 94.07% 94.05% -0.03%
+ Complexity 1096 1075 -21
=============================================
Files 197 192 -5
Lines 4323 4236 -87
=============================================
- Hits 4067 3984 -83
+ Misses 256 252 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At first it was there to mimic psr messages. But when used with
innmind/http-serverorinnmind/frameworkit feels awkward to have env variables accessible on the request as it doesn't change between 2 requests.Also env variables should be used to initialize an app and not used afterward.
So to push toward a better usage, env variables will be provided by
innmind/http-server.