Add smart icon detection and visual feedback improvements#6
Open
Inokinoki wants to merge 1 commit into
Open
Conversation
This commit implements comprehensive improvements to the EFI Boot Manager KCM, including bug fixes, missing method implementations, and enhanced visual feedback. Core Features: - Fix icon detection functions that were declared but never called - Add OS type, icon, and device icon detection to boot entries - Implement lastOperationSuccess and lastOperationEntryId properties - Add currentFilter and currentSortOrder properties for UI state tracking Bug Fixes: - Fix detailsForEntry() to include iconName, accentColor, deviceIcon, isBootNext, isCurrent - Fix wrong object reference in navigation (kcm.manager.data → entries.data) - Add missing isVisible property to delegate - Fix property access in delegate (name, entryIdHex, path → delegate.name, etc.) Missing Method Implementations: - Context menu: verifyEntryFiles, repairEntry, toggleEntryFavorite, testBootEntry, analyzeDependencies - Toolbar actions: getDiagnostics, validateEntries, verifyAllEntries, getBootStats, getBootHistory - System info: checkSecureBoot, getFirmwareInfo, autoRepairAllEntries, optimizeBootOrder - Data access: getEfiVariables, getAuditLog, benchmarkBootPerformance, getSystemBootLog - UI control: sortEntries, filterByOsType, resetFilter Enhanced OS Detection: - Add detection for: Rocky Linux, AlmaLinux, NixOS, Alpine, Void, MX Linux, deepin - Improve Ubuntu flavors: Kubuntu, Xubuntu, Lubuntu, MATE, Studio, Budgie, Kylin - Add Arch variants: Garuda, Arco Linux - Add openSUSE variants: Tumbleweed, Leap - Add Windows edition shortcuts: Win11, Win10, Win8, Win7 - Use QLatin1StringView for better performance Visual Feedback: - Add loading indicators for icon loading - Implement automatic fallback to "computer" icon on error - Enhance details dialog with status badges (Current, BootNext, Default, Visible) - Add operation result animations tied to specific entries New Signals: - dependenciesAnalyzed, diagnosticsReady, entriesValidated - bootStatsReady, bootHistoryReady, systemBootLogReady - secureBootChecked, firmwareInfoReady, bootOrderOptimized - efiVariablesReady, auditLogReady, bootBenchmarkComplete - lastOperationEntryIdChanged, currentFilterChanged, currentSortOrderChanged Code Quality: - Add validateIconName() helper function for safe icon fallback - Extract and track entryId in runAuthAction() for operation tracking - Proper error handling and null checks in all new methods - Consistent use of delegate property prefix throughout UI Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit implements comprehensive improvements to the EFI Boot Manager KCM, including bug fixes, missing method implementations, and enhanced visual feedback.
Core Features:
Bug Fixes:
Missing Method Implementations:
Enhanced OS Detection:
Visual Feedback:
New Signals:
Code Quality: