Fix copy/paste bug when assigning slider values#2
Open
fwienber wants to merge 1 commit intoInputMapper:masterfrom
Open
Fix copy/paste bug when assigning slider values#2fwienber wants to merge 1 commit intoInputMapper:masterfrom
fwienber wants to merge 1 commit intoInputMapper:masterfrom
Conversation
...to device wrapper. Instead of assigning multiple sliders to subsequent fields of deviceWrapper, always the same field Slider1 was used. Now, fields Slider1 ... Slider10 are used as intended. This should fix (multiple) sliders of DirectInput Joysticks. When trying to use a Microsoft Sidewinder Precision 2 joystick with InputMapper 1.7, I got everything to work but the acceleration control, which is reported as a slider. I stumbled upon this code, not sure whether it is the code working in IM 1.7 (it seems quite old and says something about IM 2), but thought I could give it a try. I wasn't able to build the plugin with this fix (not a C# developer), but would be glad to test with my joystick.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix copy/paste bug when assigning slider values to
device wrapper. Instead of assigning multiple sliders to
subsequent fields of
deviceWrapper, always the same fieldSlider1 was used.
Now, fields
Slider1...Slider10are used as intended.This should fix (multiple) sliders of DirectInput Joysticks.
When trying to use a Microsoft Sidewinder Precision 2
joystick with InputMapper 1.7, I got everything to work but
the acceleration control, which is reported as a slider.
I stumbled upon this code, not sure whether it is the code
working in IM 1.7 (it seems quite old and says something
about IM 2), but thought I could give it a try.
I wasn't able to build the plugin with this fix (not a C#
developer), but would be glad to test with my joystick.