chore: add apm monitoring#276
Open
laurentC35 wants to merge 8 commits into
Open
Conversation
SimonDmz
reviewed
Mar 25, 2026
| import { monitoringService } from './core/monitoring'; | ||
|
|
||
| if (monitoringService.isActive()) { | ||
| console.log('MONTIRING is active'); |
Contributor
There was a problem hiding this comment.
Suggested change
| console.log('MONTIRING is active'); | |
| console.log('MONITORING is active'); |
not so tiring 😜
|
|
||
| const syncFunction = () => { | ||
| const launchSynchronize = async () => { | ||
| synchronisationTransaction = monitoringService.startTransaction( |
Contributor
There was a problem hiding this comment.
will inactive monitoringService accept startTransaction method ?
NPE ?
| import { MONITORING_SYNC_TYPE, monitoringService } from 'core/monitoring'; | ||
| import { Transaction } from '@elastic/apm-rum'; | ||
|
|
||
| let synchronisationTransaction: Transaction | undefined; |
Contributor
There was a problem hiding this comment.
two apps sync is a mess 🙈
=> can't wait for unified synchronization 🤞
| }; | ||
|
|
||
| export const monitoringService = init({ | ||
| serviceName: 'sabiane-collecte-ui', |
Contributor
There was a problem hiding this comment.
maybe define the serviceName in viteEnv variable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature
Why
With this dependencies we can have synchronization time with this apm (we need to test it)
See docs here: https://www.elastic.co/docs/reference/apm/agents/rum-js
We can consider adding React adapter (if we want to trace specific feature with React), but I'm not sure.
The react-adapter only work with
react-routerfor monitoring route feature (and notreact-router-domortansack-router)So I think we can consider only the core package (
@elastic/apm-rum)