fix: home page update su#282
Merged
Merged
Conversation
Collaborator
Author
|
Would have been great to add tests on But i improved tests globally to ensure it's ok |
|
a6f3b6f to
1f23839
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



On the home page, we check for every survey unit if it needs to be updated in IDB adding new state (the only current case is when we need to add the
VICstate).In the same time, when we persist in IDB, now we consider the survey unit as updated, in order to put it in the next synchronization.
But there was an issue, returning a copy of current states even if there is no new state to add.
Then, when comparing current states with the copy, it considered the lists were different, so even there we did persist surveyUnit with
hasBeenUpdated:true