Skip to content

Fix BridgeNumpy include and improve module GENEX INCLUDE variables #5765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
blowekamp wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix BridgeNumpy include and improve module GENEX INCLUDE variables #5765

blowekamp wants to merge 3 commits into from
+7 −10

Conversation

@blowekamp
Copy link
Member

@blowekamp blowekamp commented Feb 3, 2026

Adresses #5756

  • Use generator expression for Python include path for build interface
  • Do not add generator expression to module system includes
  • Allow modules to override GENEX INCLUDE variables

@blowekamp
ENH: Allow modules to override GENEX INCLUDE variables
f963870 
Enable ${itk-module}_SYSTEM_GENEX_INCLUDE_DIRS, and
${itk-module}_GENEX_INCLUDE_DIRS to be set in a module's
configuration. This variable is not used as part of the ModuleInfo
cmake variables but is set as a target property for the interface
module and libraries.

This also allows modules to use generator expressions for include
paths.
@github-actions github-actions bot added type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots area:Bridge Issues affecting the Bridge module labels Feb 3, 2026
dzenanz
dzenanz reviewed Feb 3, 2026
View reviewed changes
@blowekamp blowekamp mentioned this pull request Feb 3, 2026
Closed
7 tasks
thewtex
thewtex approved these changes Feb 3, 2026
View reviewed changes
Copy link
Member

@thewtex thewtex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Brad 🙏

@blowekamp
BUG: Do not add generator expressions to module system includes
b53e305 
Generator expressions in SYSTEM_INCLUDE_DIRS were causing CMake
configuration issues. System include directories should use plain
paths without generator expressions to ensure compatibility across
different build configurations.
@blowekamp
BUG: Use generator expression for Python include path for build inter…
13844cb 
…face

Addresses issue with pixi install python in the source directory.
@blowekamp blowekamp force-pushed the cmake_genex_include branch from 3489507 to 13844cb Compare February 3, 2026 21:37
@blowekamp blowekamp marked this pull request as ready for review February 3, 2026 22:02
@blowekamp blowekamp requested a review from dzenanz February 3, 2026 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thewtex thewtex thewtex approved these changes

@dzenanz dzenanz dzenanz approved these changes

Assignees

No one assigned

Labels

area:Bridge Issues affecting the Bridge module type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@blowekamp @thewtex @dzenanz