Skip to content

BUG: use itk_module_add_library in bridge libraries#5766

Merged
blowekamp merged 1 commit intoInsightSoftwareConsortium:mainfrom
blowekamp:cmake_fix_bridge_libraries
Feb 3, 2026
Merged

BUG: use itk_module_add_library in bridge libraries#5766
blowekamp merged 1 commit intoInsightSoftwareConsortium:mainfrom
blowekamp:cmake_fix_bridge_libraries

Conversation

@blowekamp
Copy link
Member

Adresses #5761

The CMake update to use interface libraries removed the implicit directory level include. Use the itk function to explicitly add include directories to the targets.

PR Checklist

  • No API changes were made (or the changes have been approved)
  • No major design changes were made (or the changes have been approved)
  • Added test (or behavior not changed)
  • Updated API documentation (or API not changed)
  • Added license to new files (if any)
  • Added Python wrapping to new files (if any) as described in ITK Software Guide Section 9.5
  • Added ITK examples for all new major features (if any)

Refer to the ITK Software Guide for
further development details if necessary.

The CMake update to use interface libraries removed the implicit
directory level include. Use the itk function to explicitly add
include directories to the targets.
@github-actions github-actions bot added type:Bug Inconsistencies or issues which will cause an incorrect result under some or all circumstances type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots area:Bridge Issues affecting the Bridge module area:Video Issues affecting the Video module labels Feb 3, 2026
Copy link
Member

@dzenanz dzenanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. Building locally.

@dzenanz
Copy link
Member

dzenanz commented Feb 3, 2026

Builds locally with this PR.

Build started at 15:46...
1>------ Build started: Project: ITKVideoBridgeOpenCV, Configuration: RelWithDebInfo x64 ------
1>itkOpenCVVideoIOFactory.cxx
1>itkOpenCVVideoIO.cxx
1>ITKVideoBridgeOpenCV.vcxproj -> C:\Dev\ITK-vs22\lib\RelWithDebInfo\ITKVideoBridgeOpenCV-6.0.lib
2>------ Build started: Project: ITKVideoBridgeOpenCVTestDriver, Configuration: RelWithDebInfo x64 ------
2>ITKVideoBridgeOpenCVTestDriver.vcxproj -> C:\Dev\ITK-vs22\Wrapping\Generators\Python\itk\ITKVideoBridgeOpenCVTestDriver.exe
========== Build: 2 succeeded, 0 failed, 57 up-to-date, 0 skipped ==========
========== Build completed at 15:46 and took 04.342 seconds ==========

@dzenanz
Copy link
Member

dzenanz commented Feb 3, 2026

Preferably merge before 9PM for a cleaner dashboard tomorrow.

@blowekamp blowekamp marked this pull request as ready for review February 3, 2026 22:02
@blowekamp blowekamp merged commit 8b80463 into InsightSoftwareConsortium:main Feb 3, 2026
11 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:Bridge Issues affecting the Bridge module area:Video Issues affecting the Video module type:Bug Inconsistencies or issues which will cause an incorrect result under some or all circumstances type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants