COMP: Drop unused InputPixelType typedefs in CopyIterationBenchmark#114
Merged
hjmjohnson merged 1 commit intoInsightSoftwareConsortium:masterfrom Apr 23, 2026
Conversation
CopyRegionIterator and CopyScanlineIterator (examples/Core/itkCopyIterationBenchmark.cxx) each declared a local `using InputPixelType = typename TInputImage::PixelType;` that was never referenced — the loop bodies cast directly via `static_cast<OutputPixelType>(inputIt.Get())`, so InputPixelType is dead. Triggers -Wunused-local-typedefs at lines 119 and 142 under gcc. Remove the two unused typedefs; the other two functions in this file (CopyImageRegionRange, and the * / * typed-copy variant at line 187) legitimately use both InputPixelType and OutputPixelType and are left unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove two unused
using InputPixelType = ...;local typedefs inexamples/Core/itkCopyIterationBenchmark.cxxto silence-Wunused-local-typedefswarnings.Warning text
Why these two only
CopyRegionIteratorandCopyScanlineIteratorcast directly viastatic_cast<OutputPixelType>(inputIt.Get())and never referenceInputPixelTypeinside the function body — the typedef is dead.The two other copy variants in the same file legitimately use both:
*outputIt = OutputPixelType(InputPixelType(*inputIt));for (const InputPixelType & inputPixel : itk::ImageRegionRange<const TInputImage>(...))Left unchanged.