ENH: Bump ITK and replace http with https using script#23
Conversation
dzenanz
left a comment
There was a problem hiding this comment.
cmake_minimum_required of 3.10.2 is not enough.
CMake Warning at D:/a/ITKPolarTransform/ITK/CMake/ITKModuleExternal.cmake:12 (message):
-- This is needed to allow proper setting of CMAKE_MSVC_RUNTIME_LIBRARY.
-- Do not be surprised if you run into link errors of the style:
LNK2038: mismatch detected for 'RuntimeLibrary': value 'MTd_Static' doesn't match value 'MDd_Dynamic' in module.obj
cmake_minimum_required must be at least 3.16.3
Call Stack (most recent call first):
CMakeLists.txt:7 (include)
|
It looks like further minor maintenance is needed here. |
|
I've seen the failures above before, we should address at some point but they do not seem to typically fail CI. I think the main cause of failures is here: |
|
Currently, this remote is green. I prefer to wait with this PR until we fix the problems which arise from updating ITK. |
|
@jhlegarreta This PR is more thorough about replacing http by https. We can probably still use most of the changes proposed here. |
@dzenanz You have just merged PR #30, so feel free to rebase this on |
dadfb12 to
70e89da
Compare
Automated reformatting with https://github.com/InsightSoftwareConsortium/ITK/blob/master/Utilities/Maintenance/ApplyScriptToRemotes.sh