Skip to content

ci(release-please): unlock la PR de release avant le commentaire post-merge#258

Merged
InstaZDLL merged 1 commit into
mainfrom
ci/release-please-unlock-pr-before-comment
May 4, 2026
Merged

ci(release-please): unlock la PR de release avant le commentaire post-merge#258
InstaZDLL merged 1 commit into
mainfrom
ci/release-please-unlock-pr-before-comment

Conversation

@InstaZDLL
Copy link
Copy Markdown
Owner

@InstaZDLL InstaZDLL commented May 4, 2026

Summary

Quand la PR `chore(main): release …` est verrouillée (manuellement ou via une politique repo), release-please plante en exit non-zero au moment de poster son commentaire de feedback — même si le tag git et la release GitHub ont déjà été créés.

Ce patch ajoute un step avant `Run Release Please` qui :

  1. Cherche la dernière PR release-please via `gh pr list --search`
  2. Vérifie via `gh api` si elle est `locked: true`
  3. La déverrouille avec `DELETE /repos/{repo}/issues/{num}/lock`

Ainsi release-please peut finir son cycle proprement (label `autorelease: tagged`, commentaire de feedback). Aucune entrée utilisateur non-trustée n'est utilisée dans le shell.

Test plan

  • CI verte sur cette PR (push event ne trouvera aucune release PR locked à déverrouiller → no-op)
  • Au prochain merge d'une PR `feat:` / `fix:`, release-please ouvrira sa PR habituelle ; même si elle est lockée à un moment, le step de déverrouillage la rouvrira au moment du merge final

Locked release-please PRs make the action exit non-zero when it tries
to post the post-merge tagged comment, even though the tag and the
GitHub release are already created. Add a pre-step that detects the
latest release PR via gh search, checks its locked state, and unlocks
it so release-please can finish its cycle cleanly.
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 4, 2026

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (5)
  • chore: bump
  • chore(main): release
  • dependabot
  • release-please
  • [bot]

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 8e9a9978-8271-48e0-9e1b-2b7b53f34348

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ci/release-please-unlock-pr-before-comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@InstaZDLL InstaZDLL self-assigned this May 4, 2026
@InstaZDLL InstaZDLL merged commit 5e58509 into main May 4, 2026
10 checks passed
@github-actions github-actions Bot added scope: infra Docker, CI, Railway type: ci CI/CD changes labels May 4, 2026
@InstaZDLL InstaZDLL deleted the ci/release-please-unlock-pr-before-comment branch May 4, 2026 21:56
@github-actions github-actions Bot added the size: s 10-50 lines label May 4, 2026
@github-actions github-actions Bot locked and limited conversation to collaborators May 4, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

scope: infra Docker, CI, Railway size: s 10-50 lines type: ci CI/CD changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant