Skip to content
This repository was archived by the owner on Dec 29, 2025. It is now read-only.

feat: add patrol e2e testing#609

Open
ahmedAlaaInstabug wants to merge 3 commits intodevfrom
feat/add-patrol-e2e-testing
Open

feat: add patrol e2e testing#609
ahmedAlaaInstabug wants to merge 3 commits intodevfrom
feat/add-patrol-e2e-testing

Conversation

@ahmedAlaaInstabug
Copy link
Contributor

@ahmedAlaaInstabug ahmedAlaaInstabug commented Jul 24, 2025

Description of the change

feat: add patrol e2e testing

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

JIRA ID :

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests

Code review

  • This pull request has a descriptive title and information useful to a reviewer
  • Issue from task tracker has a link to this pull request

@ahmedAlaaInstabug ahmedAlaaInstabug self-assigned this Jul 24, 2025
@ahmedAlaaInstabug ahmedAlaaInstabug changed the base branch from master to dev July 24, 2025 22:08
@InstabugCI
Copy link
Collaborator

InstabugCI commented Jul 24, 2025 •
edited
Loading

Coverage Report

Label Coverage Status
Dart 83.8% ✅

Generated by 🚫 dangerJS against e2da27d

@ahmedAlaaInstabug
Squashed commit of the following:
a90a5b7 
commit fe8b5a5
Author: Ahmed alaa <aalaa@instabug.com>
Date:   Fri Jul 25 17:03:06 2025 +0300

    fix: dart format

commit 4a2305c
Author: Ahmed alaa <aalaa@instabug.com>
Date:   Fri Jul 25 16:40:50 2025 +0300

    fix: dart format

commit 6ff064e
Author: Ahmed alaa <aalaa@instabug.com>
Date:   Fri Jul 25 16:39:32 2025 +0300

    fix: dart format

commit 7d2daf6
Author: Ahmed alaa <aalaa@instabug.com>
Date:   Fri Jul 25 16:37:35 2025 +0300

    fix: dart format

commit efb1d16
Author: Ahmed alaa <aalaa@instabug.com>
Date:   Fri Jul 25 16:13:42 2025 +0300

    fix: dart format

commit fb8eb6b
Author: Ahmed alaa <aalaa@instabug.com>
Date:   Fri Jul 25 15:33:07 2025 +0300

    fix: dart format

commit 8c45834
Author: Ahmed alaa <aalaa@instabug.com>
Date:   Fri Jul 25 15:09:35 2025 +0300

    fix: dart format

commit 8cb7446
Author: Ahmed alaa <aalaa@instabug.com>
Date:   Fri Jul 25 07:24:06 2025 +0300

    fix: dart format

commit e7b8223
Author: Ahmed alaa <aalaa@instabug.com>
Date:   Fri Jul 25 06:52:01 2025 +0300

    fix: dart format

commit eb7894e
Author: Ahmed alaa <aalaa@instabug.com>
Date:   Fri Jul 25 06:22:54 2025 +0300

    fix: dart format

commit 10f8af4
Author: Ahmed alaa <aalaa@instabug.com>
Date:   Fri Jul 25 06:17:55 2025 +0300

    fix: dart format

commit 0c95d93
Author: Ahmed alaa <aalaa@instabug.com>
Date:   Fri Jul 25 06:14:08 2025 +0300

    fix: dart format

commit 1120ad3
Author: Ahmed alaa <aalaa@instabug.com>
Date:   Fri Jul 25 05:54:23 2025 +0300

    fix: dart format

commit 28845a9
Author: Ahmed alaa <aalaa@instabug.com>
Date:   Fri Jul 25 05:51:55 2025 +0300

    fix: dart format

commit fb44dcc
Author: Ahmed alaa <aalaa@instabug.com>
Date:   Fri Jul 25 05:50:48 2025 +0300

    fix: dart format

commit bb4dd19
Author: Ahmed alaa <aalaa@instabug.com>
Date:   Fri Jul 25 05:37:54 2025 +0300

    fix: dart format

commit 83e79a2
Author: Ahmed alaa <aalaa@instabug.com>
Date:   Fri Jul 25 05:35:42 2025 +0300

    fix: dart format

commit 76aaa64
Author: Ahmed alaa <aalaa@instabug.com>
Date:   Fri Jul 25 05:28:41 2025 +0300

    fix: dart format

commit 7b8d542
Author: Ahmed alaa <aalaa@instabug.com>
Date:   Fri Jul 25 05:02:00 2025 +0300

    fix: dart format

commit 8767b88
Author: Ahmed alaa <aalaa@instabug.com>
Date:   Fri Jul 25 04:46:32 2025 +0300

    fix: dart format

commit 46cc570
Author: Ahmed alaa <aalaa@instabug.com>
Date:   Fri Jul 25 04:34:10 2025 +0300

    fix: dart format

commit c7edf00
Author: Ahmed alaa <aalaa@instabug.com>
Date:   Fri Jul 25 04:20:25 2025 +0300

    fix: dart format

commit 18c20b4
Author: Ahmed alaa <aalaa@instabug.com>
Date:   Fri Jul 25 04:01:37 2025 +0300

    fix: dart format

commit ae0fd58
Author: Ahmed alaa <aalaa@instabug.com>
Date:   Fri Jul 25 04:00:18 2025 +0300

    fix: dart format

commit f78c6ad
Author: Ahmed alaa <aalaa@instabug.com>
Date:   Fri Jul 25 03:40:09 2025 +0300

    fix: dart format

commit b6e6840
Author: Ahmed alaa <aalaa@instabug.com>
Date:   Fri Jul 25 03:08:07 2025 +0300

    fix: dart format

commit 8764567
Author: Ahmed alaa <aalaa@instabug.com>
Date:   Fri Jul 25 03:04:46 2025 +0300

    fix: dart format

commit aa369c0
Author: Ahmed alaa <aalaa@instabug.com>
Date:   Fri Jul 25 02:46:43 2025 +0300

    fix: dart format

commit 111884a
Author: Ahmed alaa <aalaa@instabug.com>
Date:   Fri Jul 25 02:18:20 2025 +0300

    fix: dart format

commit 6ad5486
Author: Ahmed alaa <aalaa@instabug.com>
Date:   Fri Jul 25 01:49:27 2025 +0300

    fix: dart format

commit 9b150d6
Author: Ahmed alaa <aalaa@instabug.com>
Date:   Fri Jul 25 01:40:59 2025 +0300

    fix: dart format

commit 4836a62
Author: Ahmed alaa <aalaa@instabug.com>
Date:   Fri Jul 25 01:32:21 2025 +0300

    fix: dart format

commit 0ff5f6d
Author: Ahmed alaa <aalaa@instabug.com>
Date:   Fri Jul 25 01:27:43 2025 +0300

    fix: dart format

commit c71fcba
Author: Ahmed alaa <aalaa@instabug.com>
Date:   Fri Jul 25 01:23:46 2025 +0300

    fix: dart format

commit fe231f3
Author: Ahmed alaa <aalaa@instabug.com>
Date:   Fri Jul 25 01:19:57 2025 +0300

    fix: dart format

commit 8abdc23
Author: Ahmed alaa <aalaa@instabug.com>
Date:   Fri Jul 25 01:04:28 2025 +0300

    fix: dart format

commit 98d2659
Author: Ahmed alaa <aalaa@instabug.com>
Date:   Fri Jul 25 00:24:48 2025 +0300

    fix: dart format
@ahmedAlaaInstabug ahmedAlaaInstabug force-pushed the feat/add-patrol-e2e-testing branch from fe8b5a5 to a90a5b7 Compare July 31, 2025 11:02
@ahmedAlaaInstabug ahmedAlaaInstabug marked this pull request as ready for review July 31, 2025 11:03
@andrewdanieldev
Copy link
Contributor

andrewdanieldev commented Jul 31, 2025

@ahmedAlaaInstabug Excellent work! However, there's still a flaky iOS job that needs to be addressed.

@ahmedAlaaInstabug
Copy link
Contributor Author

ahmedAlaaInstabug commented Jul 31, 2025

@ahmedAlaaInstabug Excellent work! However, there's still a flaky iOS job that needs to be addressed.

Fixed

MoKamall
MoKamall reviewed Aug 5, 2025
View reviewed changes
.circleci/config.yml
Comment on lines 196 to +201
- run:
name: Build Example App
working_directory: example
command: flutter build ios --simulator
name: sleep 10 seconds
command: sleep 10
- run:
name: sleep 10 seconds
command: sleep 10
Copy link
Contributor

@MoKamall MoKamall Aug 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we sleeping 10 seconds two times? Would sleeping for 20 seconds once work just as fine?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@AyaMahmoud148 AyaMahmoud148 Awaiting requested review from AyaMahmoud148

2 more reviewers

@MoKamall MoKamall MoKamall left review comments

@andrewdanieldev andrewdanieldev andrewdanieldev approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

@ahmedAlaaInstabug ahmedAlaaInstabug

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ahmedAlaaInstabug @InstabugCI @andrewdanieldev @MoKamall