Conversation
I wrote an extensions allowing to use HMatrices for the boundary element toolkit BEAST.jl. The extension adds BEAST.jl as a weak dependency which means that BEAST.jl is not required as a packege but an optional add on. Only if BEAST.jl is loaded before HMatrices the extension will be available.
|
Thanks for the PR. Quick question: why not have an |
|
And I look forward to your |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #84 +/- ##
==========================================
+ Coverage 76.43% 76.73% +0.30%
==========================================
Files 14 15 +1
Lines 1477 1509 +32
==========================================
+ Hits 1129 1158 +29
- Misses 348 351 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thanks for the response, I see your point. To follow your style I will move this extension either to BEAST.jl or then to the AdaptiveCrossApproximation package. |
|
I see.... I don't have an issue having it merged here, just that it would be more natural the other way around. Feel free to re-open the PR if you for some reason you can't get it merged to BEAST. |
|
Thank you very much for the offer I will discuss it with the owner of BEAST and might reopen the pull request if I do not find another pleasing solution. |
I wrote an extensions allowing to use HMatrices for the boundary element toolkit BEAST.jl.
The extension adds BEAST.jl as a weak dependency which means that BEAST.jl is not required as a package but an optional add on. Only if BEAST.jl is loaded before HMatrices the extension will be available.
I would be pleased if this extension is accepted an merged to this package.
In addition I have wrote an AdaptiveCrossApproximation package still under development, providing different pivoting strategies as well as convergence criteria that can handle the problematic matrices appearing for integral equations such as block-structured ones.
I plan to finish and register the package in the next weeks an will provide an extension to HMatrices.jl.