Skip to content

Merging forked repository to fix typos #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Referee1405 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Merging forked repository to fix typos #52

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
57baee4
Fixed several typos
Referee1405 Aug 18, 2025
ccbf002
Merge pull request #1 from Referee1405/diff-targets-sources
Referee1405 Aug 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Kernels/helmholtz.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ where $c_j$ are the `charges` and `v_j` are the `dipvecs`.
- `k`: the wavenumber.
- `targets::Matrix{T}`: `3 x n` matrix of target points.
- `sources::Matrix{T}`: `3 x m` matrix of source points.
- `charges::Vector{Complex{T}}`: vector of `n` charges.
- `charges::Vector{Complex{T}}`: vector of `m` charges.
- `dipvecs::Matrix{Complex{T}}`: `3 x m` matrix of dipole vectors.
- `grad::Bool`: if `true`, the gradient is computed instead
- `kwargs...`: additional keyword arguments passed to [`assemble_ifgf`](@ref).
Expand Down Expand Up @@ -96,7 +96,7 @@ function helmholtz3d(L::IFGFOp; charges = nothing, dipvecs = nothing, grad = fal
error("either charges or dipvecs should be provided")
m, n = size(L)
T = isnothing(charges) ? eltype(dipvecs) : eltype(charges)
out = grad ? zeros(T, 3, m) : zeros(T, n)
out = grad ? zeros(T, 3, m) : zeros(T, m)
return helmholtz3d!(out, L; charges, dipvecs, grad)
end

Expand Down
4 changes: 2 additions & 2 deletions src/Kernels/laplace.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ where $c_j$ are the `charges` and `v_j` are the `dipvecs`.

- `targets::Matrix{T}`: `3 x n` matrix of target points.
- `sources::Matrix{T}`: `3 x m` matrix of source points.
- `charges::Vector{T}`: vector of `n` charges.
- `charges::Vector{T}`: vector of `m` charges.
- `dipvecs::Matrix{T}`: `3 x m` matrix of dipole vectors.
- `grad::Bool`: if `true`, the gradient is computed instead
- `kwargs...`: additional keyword arguments passed to [`assemble_ifgf`](@ref)
Expand Down Expand Up @@ -106,7 +106,7 @@ function laplace3d(L::IFGFOp; charges = nothing, dipvecs = nothing, grad = false
error("either charges or dipvecs should be provided")
m, n = size(L)
T = isnothing(charges) ? eltype(dipvecs) : eltype(charges)
out = grad ? zeros(T, 3, m) : zeros(T, n)
out = grad ? zeros(T, 3, m) : zeros(T, m)
return laplace3d!(out, L; charges, dipvecs, grad)
end

Expand Down
4 changes: 2 additions & 2 deletions src/Kernels/stokes.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ stresslet orientations.

- `targets::Matrix{T}`: `3 x n` matrix of target points.
- `sources::Matrix{T}`: `3 x m` matrix of source points.
- `stoklet::Matrix{T}`: `3 × n` matrix of stokeslets
- `stoklet::Matrix{T}`: `3 × m` matrix of stokeslets
- `strslet::Matrix{T}`: `6 x m` matrix of stresslet densities (indices `1:3`)
and orientations (indices `4:6`)
- `grad::Bool`: if `true`, the gradient is computed instead
Expand Down Expand Up @@ -98,7 +98,7 @@ function stokes3d(L::IFGFOp; stoklet = nothing, strslet = nothing, grad = false)
error("either stoklet or strslet should be provided")
m, n = size(L)
T = isnothing(stoklet) ? eltype(strslet) : eltype(stoklet)
out = grad ? zeros(T, 3, 3, m) : zeros(T, 3, n)
out = grad ? zeros(T, 3, 3, m) : zeros(T, 3, m)
return stokes3d!(out, L; stoklet, strslet, grad)
end

Expand Down