feat(03-backup): Scaleway backup S3 bucket foundation#41
Merged
Conversation
Provisions a Scaleway Object Storage bucket with independent lifecycle from the cluster, scoped workload credentials, configurable retention/lifecycle rules, and a dedicated CI workflow (plan on PR, apply on push, no destroy). - 03-backup/scaleway/: new Terraform root (bucket + SSE + IAM workload identity + Infisical secret storage + lifecycle rules) - 01-iam/bootstrap/scaleway: extend github-ci with ObjectStorage + IAMApplicationManager + IAMPolicyManager permissions - .github/workflows/backup_scaleway.yml: CI workflow, no scheduled destroy - Spec Kit artifacts: spec, plan, research, data-model, tasks, quickstart Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
nbrieussel
force-pushed
the
feat/03-backup-s3-foundation
branch
from
June 21, 2026 01:28
48e4dce to
cfa6fc3
Compare
nbrieussel
commented
Jun 21, 2026
- Rename IAM resources workload → kubernetes (reflects the k8s workload context for the backup identity, not a generic machine identity) - Workflow: document no-destroy domain restriction with layered rationale, fix concurrency group to workspace name (not branch), cancel-in-progress=false to avoid state corruption, add comment on command-resolution logic - Workflow: BUCKET_NAME / BUCKET_REGION → vars.BACKUP_BUCKET_NAME / BACKUP_BUCKET_REGION - main.tf: add FinOps comment on noncurrent_version_expiration - 01-iam/bootstrap/scaleway: fix stale reference to policy.tf (removed earlier) - .gitignore: ignore specs/ to reduce PR noise; untrack existing specs files Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
The backup bucket is permanently deployed — state always exists regardless of the terraform command. Read outputs unconditionally via terraform output -json instead of hardcoded GitHub vars, so the verify step always gets live values from state. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
…ction
zizmor flagged `${{ steps.tf-outputs.outputs.* }}` expanded inline in a
`run:` block as template-injection risk. Values now passed via `env:` on
the verify step so the runner sets them as environment variables before
shell execution.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
nbrieussel
marked this pull request as ready for review
June 21, 2026 12:53
nbrieussel
pushed a commit
that referenced
this pull request
Jun 21, 2026
- Rename IAM resources workload → kubernetes (reflects the k8s workload context for the backup identity, not a generic machine identity) - Workflow: document no-destroy domain restriction with layered rationale, fix concurrency group to workspace name (not branch), cancel-in-progress=false to avoid state corruption, add comment on command-resolution logic - Workflow: BUCKET_NAME / BUCKET_REGION → vars.BACKUP_BUCKET_NAME / BACKUP_BUCKET_REGION - main.tf: add FinOps comment on noncurrent_version_expiration - 01-iam/bootstrap/scaleway: fix stale reference to policy.tf (removed earlier) - .gitignore: ignore specs/ to reduce PR noise; untrack existing specs files Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacked on #40 (Spec Kit setup) — merge that first.
03-backup/scaleway/— Object Storage bucket with AES-256 SSE, versioning, configurable lifecycle rules (retention, noncurrent expiry, GLACIER transition), and a scoped workload IAM identity01-iam/bootstrap/scalewaywith ObjectStorage + IAM management permissions for thegithub-ciidentitybackup_scaleway.yml: plan on PR, apply on push to main, no scheduled destroy (FR-013)/backup/for future ESO consumptionterraform planfails ifcold_storage_transition_days >= retention_daysprevent_destroy = trueprotects bucket from Terraform-level destruction (Scaleway bucket policies do not supports3:DeleteBucket)Test plan
scw object bucket get backup-dev-id --region fr-parreturns bucket metadata (verified locally)scw object bucket getcheck passes🤖 Generated with Claude Code