[APO-120] Add visual design memory by hudsonaikins · Pull Request #9 · IntelIP/agent-permit-office

hudsonaikins · 2026-07-17T01:54:41Z

Summary

add PermitGraph product design memory and deterministic dashboard capture matrix
preserve real policy labels and prove mocked live snapshot rendering
capture from a fresh production preview
retain hidden visual evidence with artifact URIs matching the uploaded artifact
isolate the validator from candidate scanning and pin merged Tabellio c4789837

Validation

exact head fc1506d4bb88472bcc13f70ae01c08ea35623029
remote CI passed
remote PermitGraph suite passed
remote exact-head product validation passed
local tests: 17/17 passed
production dashboard build passed
production-preview visual capture matrix: 4/4 passed
cost telemetry complete: $0
evidence artifact digest: sha256:6e1d2a814e0fd54a74b4461108643dcc3c392291ee9bde4d090c37e1fb60a707
current visual baseline approved by product owner on 2026-07-16
all actionable review threads resolved

Rollout boundary

Merge authorized. Production deployment remains separately gated.

makeplane · 2026-07-17T01:54:52Z

Linked to Plane Work Item(s)

(APO-120) Adopt exact-head product validation gate

This comment was auto-generated by Plane

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8406b2aa3c

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a5795bc505

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

hudsonaikins · 2026-07-17T02:53:47Z

@codex review

hudsonaikins · 2026-07-17T02:55:25Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fc1506d4bb

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-07-17T03:07:56Z

+  "sourceCommit": null,
+  "approvedAt": null,
+  "approvedBy": null,
+  "captures": []


Record the approved visual baseline

On subsequent dashboard changes, this empty, still-proposed manifest provides no approved captures or digests against which to detect a visual regression. The visual profile only checks that four screenshots were produced (.tabellio/validators.json:35-36), so a materially altered UI can pass while merely generating a new candidate; persist the human-approved captures and source commit in this manifest so the design memory is actually durable.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-07-17T03:07:56Z

@@ -1,5 +1,6 @@
 .DS_Store
 .agent-permit/
+.artifacts/


Ignore generated validation references

The new product-validation workflow uploads generated evidence from refs/tabellio/validations/, but this ignore change covers only .artifacts/. Consequently, running the required tabellio-validate gate locally leaves the validation references as untracked files, contrary to the new AGENTS.md instruction not to commit generated evidence and making potentially sensitive proof data easy to include with git add -A; ignore the generated refs directory as well.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-07-17T03:07:56Z

+const output = resolve(repoRoot, ".artifacts/tabellio/visual-captures");
+mkdirSync(output, { recursive: true });


Clear stale screenshots before each capture run

When design:capture is rerun in a working tree after a surface, viewport, theme, or state ID has been removed or renamed, this only creates the output directory and leaves old PNGs in place. The finalizer then scans the whole directory, so its capture count and baseline candidate can include evidence produced by an earlier commit rather than the current matrix; remove and recreate the capture directory before generating screenshots.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-07-17T03:07:56Z

+          document.documentElement.classList.add(selectedTheme);
+          document.documentElement.style.colorScheme = selectedTheme;
+        }, theme);
+        await page.addStyleTag({ content: "*,*::before,*::after{animation:none!important;transition:none!important;caret-color:transparent!important}" });


Verify reduced motion before suppressing animations

If a dashboard component ignores prefers-reduced-motion, this injected rule still forcibly disables every animation and transition, so the visual gate passes despite the profile explicitly requiring reduced-motion behavior and forbidding motion without it. Keep deterministic screenshots, but first verify the application itself has suppressed or suitably reduced motion under the emulated media preference rather than masking violations with test CSS.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-07-17T03:07:56Z

+  use: {
+    ...baseConfig.use,
+    screenshot: "off",
+    trace: "off",


Pin locale and timezone for deterministic captures

When this capture configuration runs on a host with a different locale or timezone, identical commits render different visible dates and times because the dashboard calls toLocaleDateString(undefined) and toLocaleTimeString(undefined) (liveApiProjection.ts:425 and QueueStatusPanels.tsx:315). Since this context does not set locale or timezoneId, baseline candidates can differ solely by runner environment; pin both options in the design configuration.

Useful? React with 👍 / 👎.

hudsonaikins added 11 commits July 16, 2026 14:13

Add APO-120 product validation gate

165aa1d

Pin hardened Tabellio runner

ed14d79

chore(validation): separate cost evidence from outcomes

7a777d3

feat: add PermitGraph visual design memory

fc6574c

fix: preserve policy labels in visual fixtures

9452b87

chore: pin validated Tabellio release

40cd8cf

fix: provision Chromium for isolated validation

bd3add9

fix: capture dashboard from production build

e959b81

fix: override dashboard capture server

e0c375c

fix: align dashboard preview capture port

e2b7d6d

chore: advance Tabellio validation pin

a74bfec

hudsonaikins added 3 commits July 16, 2026 18:57

fix: validate exact PR head in CI

d0cd428

fix: bootstrap visual evidence finalizer

61f300f

fix: preserve visual finalizer module path

8406b2a

hudsonaikins marked this pull request as ready for review July 17, 2026 02:34

chatgpt-codex-connector Bot reviewed Jul 17, 2026

View reviewed changes

Comment thread .github/workflows/product-validation.yml

Comment thread dashboard/playwright.design.config.ts Outdated

Comment thread dashboard/playwright.design.config.ts Outdated

Comment thread .github/workflows/product-validation.yml

Comment thread .github/workflows/product-validation.yml

fix: address visual validation review findings

a5795bc

chatgpt-codex-connector Bot reviewed Jul 17, 2026

View reviewed changes

Comment thread .github/workflows/product-validation.yml Outdated

Comment thread dashboard/tests/e2e/design-memory.capture.ts

fix: bind durable live visual evidence

4710265

hudsonaikins marked this pull request as draft July 17, 2026 02:58

hudsonaikins marked this pull request as ready for review July 17, 2026 02:58

chore: pin merged Tabellio validator

fc1506d

hudsonaikins merged commit 4d89b77 into main Jul 17, 2026
3 checks passed

chatgpt-codex-connector Bot reviewed Jul 17, 2026

View reviewed changes

		const output = resolve(repoRoot, ".artifacts/tabellio/visual-captures");
		mkdirSync(output, { recursive: true });

Uh oh!

Conversation

hudsonaikins commented Jul 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Validation

Rollout boundary

Uh oh!

makeplane Bot commented Jul 17, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

hudsonaikins commented Jul 17, 2026

Uh oh!

hudsonaikins commented Jul 17, 2026

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Jul 17, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot Jul 17, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot Jul 17, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot Jul 17, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot Jul 17, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

hudsonaikins commented Jul 17, 2026 •

edited

Loading