Make SequentialDict return outputs from all modules as DotDict#171
Merged
Make SequentialDict return outputs from all modules as DotDict#171
SequentialDict return outputs from all modules as DotDict#171Conversation
This reverts commit 01a2066.
dxoigmn
changed the title
SequentialDict return outputs from all modulesSequentialDict return outputs from all modules as DotDict
mzweilin
requested changes
Jun 22, 2023
Contributor
mzweilin
left a comment
mzweilin
left a comment
There was a problem hiding this comment.
It looks like there're merged changes in mart/models/modular.py.
I will review again after you merge main into this.
Member
Author
Should be good to review. |
mzweilin
approved these changes
Jun 22, 2023
Contributor
mzweilin
left a comment
mzweilin
left a comment
There was a problem hiding this comment.
LGTM.
Shall we just delete ReturnKwargs in mart.nn?
Member
Author
|
Leave it for now because some modules still use it. Making everything tidier should be a different PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Right now
SequentialDictonly returns theoutputmodule. This requires hardcoding a module with that name and often makes configuration more verbose than necessary. This PR removes that requirement and simplifies configuration by returning all outputs in the form of aDotDict. This is a breaking change and also removesReturnKwargssince it is unnecessary.This PR depends upon the following:
LitModular.*_step_logto be a dictionary #168LitModular#169*_step_endfromLitModular#170Type of change
Please check all relevant options.
Testing
Please describe the tests that you ran to verify your changes. Consider listing any relevant details of your test configuration.
pytestCUDA_VISIBLE_DEVICES=0 python -m mart experiment=CIFAR10_CNN_Adv trainer=gpu trainer.precision=16reports 70% (21 sec/epoch).CUDA_VISIBLE_DEVICES=0,1 python -m mart experiment=CIFAR10_CNN_Adv trainer=ddp trainer.precision=16 trainer.devices=2 model.optimizer.lr=0.2 trainer.max_steps=2925 datamodule.ims_per_batch=256 datamodule.world_size=2reports 70% (14 sec/epoch).Before submitting
pre-commit run -acommand without errorsDid you have fun?
Make sure you had fun coding 🙃