-
Notifications
You must be signed in to change notification settings - Fork 23
Resolve compute follows data issue in logspace and geomspace functions #2723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
antonwolfy
wants to merge
6
commits into
master
Choose a base branch
from
resolve-gh-2352-2353
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+197
−195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
View rendered docs @ https://intelpython.github.io/dpnp/pull/2723/index.html |
Contributor
|
Array API standard conformance tests for dpnp=0.20.0dev1=py313h509198e_62 ran successfully. |
Collaborator
8f2b44c to
a040d0a
Compare
a040d0a to
282c0ef
Compare
…trization through pytest
d337076 to
b345077
Compare
b345077 to
7cfd0a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR closes #2352 and closes #2353.
This PR improves implementation of
dpnp.logspaceanddpnp.geomspacefunctions based on the latest changes added to NumPy.And it also updates logic of how input array_like arguments handled to follow compute follows data approach.
If no
deviceorsycl_queuekeyword passed, then an array creation function should allocate result based on input arguments (likestartandstop).Otherwise all input arrays need to be moved to the specified queue and resulting array must be allocated there.