Skip to content

Deprecate setting the strides attribute of dpnp array #2732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vlad-perevezentsev wants to merge 3 commits into from
Closed

Deprecate setting the strides attribute of dpnp array #2732

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9bf1b1d
Deprecate setting the strides of dpnp array
vlad-perevezentsev Jan 20, 2026
5630096
Add test_set_strides_deprecated
vlad-perevezentsev Jan 20, 2026
3acb0a0
Merge master into depr_strides_set
vlad-perevezentsev Jan 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions dpnp/dpnp_array.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1866,6 +1866,16 @@ def strides(self):

return self._array_obj.strides

@strides.setter
def strides(self, _value):
warnings.warn(
"Setting the strides attribute is deprecated. "
"As an alternative, you can create a new view (no copy) via "
"the dpnp.ndarray constructor (``buffer`` is the original array).",
DeprecationWarning,
stacklevel=2,
)

def sum(
self,
/,
Expand Down
5 changes: 5 additions & 0 deletions dpnp/tests/test_ndarray.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,11 @@ def test_attributes(self):
assert_equal(self.two.nbytes, 20 * num)
assert_equal(self.two.itemsize, self.two.dtype.itemsize)

def test_set_strides_deprecated(self):
x = dpnp.eye(2)
with pytest.warns(DeprecationWarning, match="Setting the strides"):
setattr(x, "strides", x.strides)
Copy link
Contributor

@antonwolfy antonwolfy Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need some validation the strides really changed



@testing.parameterize(*testing.product({"xp": [dpnp, numpy]}))
class TestContains:
Expand Down
Loading