Skip to content

Clarify axes keyword in tensordot function #2733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
antonwolfy merged 3 commits into from
Jan 21, 2026
Merged

Clarify axes keyword in tensordot function #2733

antonwolfy merged 3 commits into from
Jan 21, 2026
+30 −4

Conversation

@antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Jan 21, 2026 •
edited
Loading

The PR extends docstrings to clarify behavior on repeated values passed in axes to tensordot functions.
Also an explicit test was added to validate the exception raised on the repeated axes.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?

@antonwolfy antonwolfy added this to the 0.20.0 release milestone Jan 21, 2026
@antonwolfy antonwolfy self-assigned this Jan 21, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 21, 2026

View rendered docs @ https://intelpython.github.io/dpnp/pull/2733/index.html

@antonwolfy antonwolfy marked this pull request as ready for review January 21, 2026 13:39
@github-actions
Copy link
Contributor

github-actions bot commented Jan 21, 2026

Array API standard conformance tests for dpnp=0.20.0dev1=py313h509198e_58 ran successfully.
Passed: 1226
Failed: 1
Skipped: 9

@coveralls
Copy link
Collaborator

coveralls commented Jan 21, 2026

Coverage Status

coverage: 81.095%. remained the same
when pulling 8ce6785 on clarify-axes-in-tensordot
into e9a79f4 on master.

vlad-perevezentsev
vlad-perevezentsev approved these changes Jan 21, 2026
View reviewed changes
Copy link
Contributor

@vlad-perevezentsev vlad-perevezentsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thank you @antonwolfy

@antonwolfy antonwolfy merged commit 7d4d2a0 into master Jan 21, 2026
72 of 97 checks passed
@antonwolfy antonwolfy deleted the clarify-axes-in-tensordot branch January 21, 2026 15:51
github-actions bot added a commit that referenced this pull request Jan 21, 2026
@github-actions
Clarify axes keyword in tensordot function (#2733)
46d420a 
The PR extends docstrings to clarify behavior on repeated values passed
in `axes` to `tensordot` functions.
Also an explicit test was added to validate the exception raised on the
repeated axes. 7d4d2a0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vlad-perevezentsev vlad-perevezentsev vlad-perevezentsev approved these changes

@ndgrigorian ndgrigorian Awaiting requested review from ndgrigorian ndgrigorian is a code owner

Assignees

@antonwolfy antonwolfy

Labels

None yet

Projects

None yet

Milestone

0.20.0 release

Development

Successfully merging this pull request may close these issues.

3 participants

@antonwolfy @coveralls @vlad-perevezentsev