Skip to content

Add configurable X/Z offset#237

Open
InstantlyMoist wants to merge 1 commit into
IntellectualSites:mainfrom
InstantlyMoist:feature/configurable-offset
Open

Add configurable X/Z offset#237
InstantlyMoist wants to merge 1 commit into
IntellectualSites:mainfrom
InstantlyMoist:feature/configurable-offset

Conversation

@InstantlyMoist

Copy link
Copy Markdown

Overview

Simply adds a configurable X/Z offset, as I needed that and might be useful to others.

Description

It renames 'offset' to 'offset_y' and adds 'offset_x' + 'offset_z' as I didnt want the hologram to appear on top of the road, but rather the border.

Submitter Checklist

  • Make sure you are opening from a topic branch (/feature/fix/docs/ branch (right side)) and not your main branch.
  • Ensure that the pull request title represents the desired changelog entry.
  • New public fields and methods are annotated with @since TODO.
  • I read and followed the contribution guidelines.

@InstantlyMoist InstantlyMoist requested a review from a team as a code owner July 8, 2025 14:33
@PierreSchwang

Copy link
Copy Markdown
Member

The solution is generally fine, though I'm not the biggest fan of simply dropping a configuration property.

I am quite unsure if it would be better to make the sign location configurable in PlotSquared itself (which would propagate to HoloPlots) - or if those should be separate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants