Improved logic to determine which plots to update on chunk load/unload#274
Open
InstantlyMoist wants to merge 1 commit into
Open
Improved logic to determine which plots to update on chunk load/unload#274InstantlyMoist wants to merge 1 commit into
InstantlyMoist wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Description
I noticed high usage from this plugin when it comes to joining an empty plot world, after debugging I found out that it called
createOrUpdateHologrammultiple times for the same plot, sometimes up to 11 times.To mitigate this issue, I check the 4 corners of the loaded chunk and check if the sign position falls within this chunk. Whilst also keeping track we haven't processed this chunk yet. This reduced my updates from 6-11 per plot to 1.
Open to feedback, this solution made sense to me as the sign location is 'one case'.
Submitter Checklist
@since TODO.