Skip to content

Improved logic to determine which plots to update on chunk load/unload#274

Open
InstantlyMoist wants to merge 1 commit into
IntellectualSites:mainfrom
InstantlyMoist:fix/duplicate-update-calls
Open

Improved logic to determine which plots to update on chunk load/unload#274
InstantlyMoist wants to merge 1 commit into
IntellectualSites:mainfrom
InstantlyMoist:fix/duplicate-update-calls

Conversation

@InstantlyMoist

Copy link
Copy Markdown

Overview

Description

I noticed high usage from this plugin when it comes to joining an empty plot world, after debugging I found out that it called createOrUpdateHologram multiple times for the same plot, sometimes up to 11 times.

To mitigate this issue, I check the 4 corners of the loaded chunk and check if the sign position falls within this chunk. Whilst also keeping track we haven't processed this chunk yet. This reduced my updates from 6-11 per plot to 1.

Open to feedback, this solution made sense to me as the sign location is 'one case'.

Submitter Checklist

  • Make sure you are opening from a topic branch (/feature/fix/docs/ branch (right side)) and not your main branch.
  • Ensure that the pull request title represents the desired changelog entry.
  • New public fields and methods are annotated with @since TODO.
  • I read and followed the contribution guidelines.

@InstantlyMoist
InstantlyMoist requested a review from a team as a code owner March 30, 2026 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant