Skip to content

Fix menu bar color changing logic#3

Open
J-M0 wants to merge 2 commits intoIntelliScape:masterfrom
J-M0:highlight-fix
Open

Fix menu bar color changing logic#3
J-M0 wants to merge 2 commits intoIntelliScape:masterfrom
J-M0:highlight-fix

Conversation

@J-M0
Copy link

@J-M0 J-M0 commented Oct 10, 2022

The old logic for determining whether to display in dark mode or not doesn't work any more as the color of the menu bar isn't connected to whether the system is in dark mode or not.

Additionally, it's not the style any more to highlight menu bar icons when clicked on. Doing so makes them hard to see.

J-M0 added 2 commits October 10, 2022 19:12
Starting at least in Catalina, it's not the style for
menu bar items to change color when clicked.
Starting at least in Big Sur, the menu bar may display icons
in dark/highlighted mode even if the system theme is not in dark mode.

This can occur when the menu bar is shown in fullscreen mode or
depending on the desktop wallpaper.
@ismaelit
Copy link

I am actually using Ventura 13.0.1 on M1 and Caffeine 1.1.3, the icon is always black. Hope this fix solves it in the next update.

@tzimpel
Copy link

tzimpel commented Dec 14, 2022

I am actually using Ventura 13.0.1 on M1 and Caffeine 1.1.3, the icon is always black. Hope this fix solves it in the next update.

I have the same issue. Will this be merged in the near future?

@ishche
Copy link

ishche commented Jul 30, 2024

image Hi! Could you please merge and release the fix? :)

@toxig
Copy link

toxig commented Nov 25, 2024

The problem still actual on Mac OS Sonoma 14.5

Icon hidden in bar with dark OS theme:
image

Icon is visible only by right click:
image

Fix it please 🙏 many thanks in advance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants