fix(pull-sdlc): restore blank-line separators dropped by stream refactor (#194)#197
Merged
Conversation
…e footers The output-stream refactor (#194) dropped two Write-Host '' separators when converting the footers to Write-Information, so the -WhatIf specified; no changes written. and Already up to date. lines printed flush against the planned-ops preview. Restore the separators as Write-Information '' (same stream as the footer so they suppress/redirect together). Not added to the preview helper or the apply path -- the Applied N ops. line never had a leading blank line. Closes #196 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The output-stream refactor (#194 / #195) dropped two blank-line separators that the original code emitted via
Write-Host '', so the-WhatIf specified; no changes written.andAlready up to date.footers printed flush against the planned-ops preview.Before (regression)
After (restored)
Change
Write-Information ''before each footer (same stream as the footer message, so they suppress/redirect together via6>).Write-PlannedOpsPreviewor the apply path -- theApplied N ops.line never had a leading blank line, so it stays unchanged.Tests
Two behavior-first tests added to the
Output stream assignment (issue #194)block, asserting the Information-stream record immediately before each footer is an empty string. Both fail on the pre-fix code (separator absent) and pass after.Invoke-Pester -Path .\Pull-SDLC.ai.Tests.ps1-> 201 passed, 0 failedInvoke-ScriptAnalyzer -Path .\Pull-SDLC.ai.ps1 -Severity Warning,Error-> no new findings (PSAvoidUsingWriteHoststill 0)Closes #196