Skip to content

add nbtHash to itemstacks#808

Open
Bubbet wants to merge 2 commits intoIntelligenceModding:dev/1.20.1from
Bubbet:dev/1.20.1
Open

add nbtHash to itemstacks#808
Bubbet wants to merge 2 commits intoIntelligenceModding:dev/1.20.1from
Bubbet:dev/1.20.1

Conversation

@Bubbet
Copy link

@Bubbet Bubbet commented Feb 15, 2026

PLEASE READ THE GUIDELINES BEFORE MAKING A CONTRIBUTION

  • Please check if the PR fulfills these requirements
  • The commit message are well described
  • Docs have been added / updated (for features or maybe bugs which were noted). If not, please update the needed documentation here. Feel free to remove this check if you don't need it
  • All changes have fully been tested
  • What kind of change does this PR introduce? (Bug fix, feature, ...)
    Feature

  • What is the current behavior? (You can also link to an open issue here)
    No CC:T nbt hash included, only a table of nbt tags

  • What is the new behavior (if this is a feature change)?
    Added nbtHash, the hash CC:T would have made.

  • Does this PR introduce a breaking change? (What changes might users need to make in their scripts due to this PR?)
    No

  • Other information:
    Not sure if fluids also have nbt, I only did the one area.

@SirEndii
Copy link
Member

Why do you remove cound and name?
And change the way the table is generated

@github-actions
Copy link
Contributor

github-actions bot commented Feb 15, 2026

Build Preview

badge

You can find files attached to the below linked Workflow Run URL (Logs).

Name Link
Commit 7118768
Logs https://github.com/IntelligenceModding/AdvancedPeripherals/actions/runs/22043420271

@Bubbet
Copy link
Author

Bubbet commented Feb 15, 2026

Those are included in that table that gets returned from what's inside the hashmap constructor. Tags are also included in those details. So that other method isn't necessary anymore?

@Bubbet
Copy link
Author

Bubbet commented Feb 15, 2026

I only kept "maxStackSize" because its named differently, theres maxCount in that details too

@SirEndii
Copy link
Member

We can move the system in the future to use the DetailRegistry from CC in the right way but for now, I recommend to add it manually

https://github.com/cc-tweaked/CC-Tweaked/blob/4bc04f14162aac62cb26dd6792fcd46413beb526/projects/common/src/main/java/dan200/computercraft/shared/details/ItemDetails.java#L32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants