transaction and request ID clarifications#153
Open
robhazan wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
See InteractiveAdvertisingBureau/openrtb2.x#88 for the matching PR in /openrtb2,.x @wittjill - I can't seem to add reviewers here. Can you please add the same reviewers we have on that other PR (and/or others that you see fit)? |
|
revert-191-revert-189-patch-1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added some language to clarify how the SupplyChainNode rid field is intended to be used, as well as clarifying the limitations of the tid field in Source. I do think we should concurrently consider moving per-impression transaction IDs out of community extension into mainline of OpenRTB via Provisional.
I'm creating a matching PR for the /openrtb2.x (2.6) repo.