Harden auth and client security boundaries#15
Merged
Conversation
- Mark JWT cookie HttpOnly on set and clear in relay server\n- Pin auth/session endpoints to trusted backend origin in config/audit service\n- Move chat keypair storage out of localStorage and migrate legacy keys\n- Escape untrusted relay/bootstrap labels in settings alerts\n- Add noopener noreferrer to external Tor guide link\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This hardens several high-risk trust boundaries found in the security audit: session token exposure in cookies, mutable auth endpoint routing, private key persistence in localStorage, and unescaped untrusted text in settings alerts.
What changed
jwtcookie asHttpOnlyboth when setting and clearing it inrelay-server/relay-server-enhanced.js.src/config.ts(config.auth.api) and updatedAuditServiceauth/session calls (/api/me, vote authorize/confirm, poll-policy, OAuth start) to use it instead of mutable relay overrides.src/services/chatService.ts:StorageServicelocalStoragekeypairs are migrated once and removedalertControllercontent insrc/views/SettingsPage.vue.rel="noopener noreferrer"to the external Tor Browser link insrc/views/ResiliencePage.vue.src/services/copilot-services.mdto reflect chat key storage hardening.package-lock.jsonupdated from dependency install during verification.Notes for reviewers