Skip to content

Implement cardano-config migrate#3

Merged
jasagredo merged 6 commits into
mainfrom
js/migrate
Jul 13, 2026
Merged

Implement cardano-config migrate#3
jasagredo merged 6 commits into
mainfrom
js/migrate

Conversation

@jasagredo

@jasagredo jasagredo commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Migrates from this:

image

to this:

image

Renames some fields:

renamedFields =
  [ -- gRPC local-connection keys (were named Rpc)
    ("EnableRpc", "EnableGrpc")
  , ("RpcSocketPath", "GrpcSocketPath")
  , -- Deadline peer targets (gained the Deadline prefix)
    ("TargetNumberOfRootPeers", "DeadlineTargetNumberOfRootPeers")
  , ("TargetNumberOfKnownPeers", "DeadlineTargetNumberOfKnownPeers")
  , ("TargetNumberOfEstablishedPeers", "DeadlineTargetNumberOfEstablishedPeers")
  , ("TargetNumberOfActivePeers", "DeadlineTargetNumberOfActivePeers")
  , ("TargetNumberOfKnownBigLedgerPeers", "DeadlineTargetNumberOfKnownBigLedgerPeers")
  , ("TargetNumberOfEstablishedBigLedgerPeers", "DeadlineTargetNumberOfEstablishedBigLedgerPeers")
  , ("TargetNumberOfActiveBigLedgerPeers", "DeadlineTargetNumberOfActiveBigLedgerPeers")
  ]

acceptedConnectionsLimitFields :: [(Text, Text)]
acceptedConnectionsLimitFields =
  [ ("hardLimit", "HardLimit")
  , ("softLimit", "SoftLimit")
  , ("delay", "Delay")
  ]

Removes some other fields:

removedFields =
  [ "PBftSignatureThreshold"
  , "LastKnownBlockVersion-Major"
  , "LastKnownBlockVersion-Minor"
  , "LastKnownBlockVersion-Alt"
  , "Protocol"
  , "MaxKnownMajorProtocolVersion"
  ]

tracingObsoleteKeys :: [Text]
tracingObsoleteKeys =
  [ "UseTraceDispatcher"
  , "TurnOnLogging"
  , "TurnOnLogMetrics"
  , "defaultBackends"
  , "defaultScribes"
  , "setupBackends"
  , "setupScribes"
  , "minSeverity"
  , "options"
  ]

@jasagredo
jasagredo force-pushed the js/migrate branch 2 times, most recently from 549df54 to 7244dcb Compare July 1, 2026 14:58
@jasagredo
jasagredo changed the base branch from js/cardano-config to js/tracing July 1, 2026 14:59
@jasagredo
jasagredo force-pushed the js/tracing branch 2 times, most recently from f6b396e to 7655e4e Compare July 2, 2026 08:06
Base automatically changed from js/tracing to main July 3, 2026 09:06
@jasagredo
jasagredo marked this pull request as ready for review July 3, 2026 12:27
Comment thread src/Cardano/Configuration/File/Migrate.hs Outdated
Comment thread src/Cardano/Configuration/File/Migrate.hs Outdated
Comment thread src/Cardano/Configuration/File.hs Outdated
Comment thread src/Cardano/Configuration/File/Migrate.hs Outdated
Comment thread src/Cardano/Configuration/File/Migrate.hs Outdated
@jasagredo
jasagredo requested a review from dnadales July 13, 2026 14:57
@jasagredo
jasagredo enabled auto-merge (squash) July 13, 2026 15:10

@dnadales dnadales left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for implementing these improvements!

@jasagredo
jasagredo merged commit 039d472 into main Jul 13, 2026
16 checks passed
@jasagredo
jasagredo deleted the js/migrate branch July 13, 2026 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants