ci: add Husky pre-commit hooks for lint and formatting#250
Open
AGWAM001 wants to merge 1 commit into
Open
Conversation
|
@AGWAM001 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Please resolve conflict |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #227
Summary
Sets up Husky pre-commit and pre-push hooks with
lint-stagedto catch lint errors, formatting issues, and type errors locally before they reach CI.Changes
huskyandlint-stagedas dev dependencieslint-stagedto runeslint --fixandprettier --writeon staged.ts/.tsx/.js/.jsxfiles on pre-committsc --noEmitand catch type errors before pushCONTRIBUTING.mdHow to test
npm installto set up hooksgit commit— the hook should auto-fix and block the commit if unfixable errors remaingit pushon a branch with a TypeScript error — the pre-push hook should fail and prevent the pushNotes
tsc --noEmitruns project-wide on push, not scoped to staged files, to ensure full type safetynpm installafter cloning to activate the hooks (documented inCONTRIBUTING.md)