Conversation
## Summary - Consolidate demo auth, route metadata, report export helpers, and release docs into reusable modules. - Remove stale docs, generated reports, unused assets, dead components, orphan hooks, and unused dependencies. - Fix remaining action gaps across reports, backups, audit filters, uploaded-file management, profile dialogs, and settings controls. ## Changes Made ### Architecture - Centralized seeded demo account metadata and role route mapping. - Moved app route definitions into a reusable route registry. - Added typed report export filtering and simplified dashboard data shaping. ### Cleanup - Removed stale release notes, old evidence files, generated Playwright report output, unused UI modules, orphan hooks, and unused bucket/database helpers. - Optimized PWA/fav icon assets and removed unused React/logo source assets. - Removed unused dependencies from package metadata and lockfile. ### Product Fixes - Wired admin audit-log email and action filters. - Enabled backup export, report date filtering, faculty dark mode, uploaded-file category persistence/removal, and profile dialog close/accessibility behavior. - Suppressed expected optional missing profile-image noise while preserving real storage error logging. ### Verification - Added unit coverage for reusable auth/routes/report helpers. - Added Playwright coverage for admin action controls, management exports, faculty settings, profile edits, and uploaded-file persistence. ## Why - The project needed a cleaner plug-and-play structure, less stale surface area, smaller asset/dependency footprint, and stronger E2E evidence for user-facing controls. ## Notes for Reviewers - Remaining unused-export scan findings are intentionally retained shared UI primitive exports for future component reuse. - Final verification before commit passed lint, unit tests, security scan, SEO/link checks, audit, build, and both local and Pages-style Playwright runs.
Iron-Mark
marked this pull request as ready for review
June 25, 2026 05:34
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The repo needed a cleaner architecture, fewer stale files, smaller asset/dependency surface area, and stronger evidence that the demo works end to end across user-facing controls.
Verification
npm run lintnpm test -- --run-> 21 files, 52 tests passednpm run security:scannpm run seo:checknpm run links:checknpm audit --audit-level=moderate-> 0 vulnerabilitiesnpm run buildnpx playwright test --reporter=line-> 26/26 passedgit diff --checkpassed with Windows LF-to-CRLF notices onlyNotes
knipunused-export findings are shared UI primitive exports intentionally kept for future reusable component/API surface.