Docker open issue for licensed repos #136
Conversation
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 1ac4181 |
.github/workflows/docker.yaml
Outdated
| run: | | ||
| IMAGE_NAME=$(echo "${{inputs.image_name}}" | sed 's|.*/||') | ||
| if jq -e --arg name "$IMAGE_NAME" '.[] == $name' licensed-images.json > /dev/null; then | ||
| echo "Match found". |
There was a problem hiding this comment.
Nitpick: The . should be in the quotes or be removed.
| needs: [publish, image] | ||
| runs-on: ${{ inputs.other_jobs_runs_on }} | ||
| if: needs.image.outputs.prerelease == 'false' | ||
| steps: |
There was a problem hiding this comment.
Don't we need to do the google-github-actions/auth@v3 and checkout also? This is a separate job.
There was a problem hiding this comment.
I wondered that... but it seemed to work... So I really don't know
There was a problem hiding this comment.
We shouldn't need the checkout since it doesn't interact with any files in the repo itself though, right?
|
craig ~/Repos/workflows [main] $ git tag -f docker-v1
|
No description provided.