Fix Vanilla Bug, use official Hytale API for ActiveChunkUnloader with configurable offset and implement chunkunloader whitelist#20
Open
Xytronix wants to merge 3 commits intoIroriPowered:masterfrom
Conversation
… configurable offset and implement chunkunloader whitelist
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a bug where paused players' chunks unload when standing still on pause screen for 7,5 seconds.
I implemented a configurable spawn exclusion list and rewrote ActiveChunkUnloader to use official patched methods.
Key changes:
ChunkUnloadingSystemto skip paused players (nulltransformComponent)/refixes chunkloadercommand, supports add, remove and listType of change
Implementation details
MixinChunkUnloadingSystem: OverwrotecollectTrackers()to useChunkTracker.shouldBeVisible()instead ofgetChunkVisibility(), properly handling paused playersMixinPlayerChunkTrackerSystems: SetsminLoadedChunksRadiuson player addMixinPlayerViewRadius: Updates radius when view distance changes dynamicallyActiveChunkUnloader: Reduced in size and uses now official vanilla APIChunkLoaderService: Managing persistent chunk loadersChunkLoaderCommand: Command with support for coordinates, current position and labelChunkLoaderWorldListener: Restores chunk loaders on world loadhytale.command.refixes.chunkloader.{add,remove,list}Checklist