Fix File → Export… → Games in filter action to export only games in the current filter#107
Open
AJWilderland wants to merge 1 commit intoIsarhamster:masterfrom
Open
Fix File → Export… → Games in filter action to export only games in the current filter#107AJWilderland wants to merge 1 commit intoIsarhamster:masterfrom
AJWilderland wants to merge 1 commit intoIsarhamster:masterfrom
Conversation
Author
|
Thank you for reviewing this fix. This PR addresses a long-standing mismatch between the filtered games displayed in the UI and the list of games actually exported by the Export… → Games in filter command. If further adjustments are needed (e.g., updating unit tests, adding a UI tooltip), I can submit a follow-up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
File → Export… → Games in filterin ChessX exports the correct number of games, but the wrong subset: it writes the first N games of the database instead of the filtered games.Root cause
Output::outputUtf8(QTextStream&, FilterX&)andOutput::outputLatin1(QDataStream&, FilterX&)iterate:Here
filter.count()is the number of included games, butiis used as a database index. This ignores the mask infilter.Fix
filter.size()).i, checkfilter.contains(i)to test membership.filter.database()->loadGame(i, game).doneCountwhich is incremented only for included games to compute progress.No changes to UI,
GameList, orFilterModel. The export records now matches the filtered view.