Closed
Conversation
The current hack with explicit "install" invocation is broken because it doesn't respect the $(INSTALL_ROOT) variable. Avoid manual installation of the icons by naming all of them "chessx.png" and placing them into individual subdirectories according to the size. Unfortunately the native Qt install targets do not provide a way to rename the files when installing, so this is the only way to avoid running unix commands by hand. Signed-off-by: Ondrej Mosnacek <omosnace@redhat.com>
In the pkgProj file there are some absolute paths that does not exist in most systems, and thus **I believe** they could be referenced as relative paths
…to new-icon-set
Contributor
Owner
|
I had changed the icon in the meantime to the colors of freedom. I leave this open as I might use it in the future. |
Contributor
Hi @Isarhamster |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request redesigns and redraws ChessX Icon with a scalable (svg) and a complete icon set
https://github.com/IAHM-COL/chessx/tree/new-icon-set/data/icons
Note that this pull request also merges the following pulls:
Note: Icon implementation tested on Linux, but it should work cross platform