Skip to content

Update assembly definitions and project settings for improved test compilation and dependency management #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
IvanMurzak merged 2 commits into from
Jan 7, 2026
Merged

Update assembly definitions and project settings for improved test compilation and dependency management #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dcada99
Update assembly definitions and project settings for improved test co…
IvanMurzak Jan 7, 2026
88155a9
Bump version to 2.1.2 in Installer and package.json
IvanMurzak Jan 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Installer/Assets/PlayerPrefsEx Installer/Installer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ namespace Extensions.Unity.PlayerPrefsEx.Installer
public static partial class Installer
{
public const string PackageId = "extensions.unity.playerprefsex";
public const string Version = "2.1.1";
public const string Version = "2.1.2";

static Installer()
{
Expand Down
10 changes: 4 additions & 6 deletions Unity-Package/Assets/root/Tests/Editor/Extensions.Unity.PlayerPrefsEx.Editor.Tests.asmdef
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "Extensions.Unity.PlayerPrefsEx.Editor.Tests",
"rootNamespace": "Extensions.Unity.PlayerPrefsEx.Tests",
"rootNamespace": "",
Copy link

Copilot AI Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rootNamespace has been cleared to an empty string, but the actual test files in this directory use the namespace Extensions.Unity.PlayerPrefsEx.Editor.Tests. This mismatch means the rootNamespace setting won't provide the intended namespace enforcement. Consider setting rootNamespace to "Extensions.Unity.PlayerPrefsEx.Editor.Tests" to match the actual test files.

Suggested change
"rootNamespace": "",
"rootNamespace": "Extensions.Unity.PlayerPrefsEx.Editor.Tests",

Copilot uses AI. Check for mistakes.
"references": [
"UnityEditor.TestRunner",
"UnityEngine.TestRunner",
Expand All @@ -11,11 +11,9 @@
],
"excludePlatforms": [],
"allowUnsafeCode": false,
"overrideReferences": true,
"precompiledReferences": [
"nunit.framework.dll"
],
"autoReferenced": false,
"overrideReferences": false,
"precompiledReferences": [],
Comment on lines +14 to +15
Copy link

Copilot AI Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Editor tests assembly has overrideReferences set to false and an empty precompiledReferences array, while the Runtime tests assembly has overrideReferences set to true with "nunit.framework.dll" in precompiledReferences. This inconsistency could cause issues with NUnit framework availability. For Unity's Test Framework, editor tests typically don't need to override references since they automatically get NUnit through UnityEditor.TestRunner. However, the Runtime tests configuration should either match the Editor tests approach (both set to false with empty precompiledReferences) or both should consistently specify their NUnit dependencies.

Suggested change
"overrideReferences": false,
"precompiledReferences": [],
"overrideReferences": true,
"precompiledReferences": [
"nunit.framework.dll"
],

Copilot uses AI. Check for mistakes.
"autoReferenced": true,
"defineConstraints": [],
Copy link

Copilot AI Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Runtime tests assembly has defineConstraints set to ["UNITY_INCLUDE_TESTS"] but the Editor tests assembly doesn't have this constraint. For consistency, both test assemblies should use the same define constraints. The UNITY_INCLUDE_TESTS define is a standard Unity symbol for test-only code and should be applied consistently across both editor and runtime test assemblies.

Suggested change
"defineConstraints": [],
"defineConstraints": [
"UNITY_INCLUDE_TESTS"
],

Copilot uses AI. Check for mistakes.
"versionDefines": [],
"noEngineReferences": false
Expand Down
8 changes: 5 additions & 3 deletions Unity-Package/Assets/root/Tests/Runtime/Extensions.Unity.PlayerPrefsEx.Tests.asmdef
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "Extensions.Unity.PlayerPrefsEx.Tests",
"rootNamespace": "Extensions.Unity.PlayerPrefsEx.Tests",
"rootNamespace": "",
Copy link

Copilot AI Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rootNamespace has been cleared to an empty string, but the actual test files in this directory use the namespace Extensions.Unity.PlayerPrefsEx.Tests.Runtime. This mismatch means the rootNamespace setting won't provide the intended namespace enforcement. Consider either setting rootNamespace to "Extensions.Unity.PlayerPrefsEx.Tests.Runtime" to match the actual test files, or leaving it as the parent namespace "Extensions.Unity.PlayerPrefsEx.Tests" if you want flexibility for sub-namespaces.

Suggested change
"rootNamespace": "",
"rootNamespace": "Extensions.Unity.PlayerPrefsEx.Tests",

Copilot uses AI. Check for mistakes.
"references": [
"UnityEngine.TestRunner",
"Extensions.Unity.PlayerPrefsEx"
Expand All @@ -12,8 +12,10 @@
"precompiledReferences": [
"nunit.framework.dll"
],
"autoReferenced": false,
"defineConstraints": [],
"autoReferenced": true,
"defineConstraints": [
"UNITY_INCLUDE_TESTS"
],
"versionDefines": [],
"noEngineReferences": false
}
2 changes: 1 addition & 1 deletion Unity-Package/Assets/root/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"name": "Ivan Murzak",
"url": "https://github.com/IvanMurzak"
},
"version": "2.1.1",
"version": "2.1.2",
"unity": "2018.3",
"description": "Lightweight package with optimized advanced version of PlayerPrefs. Under the hood it uses the same PlayerPrefs system, but creates flexible wrapper for default system.",
"keywords": [
Expand Down
2 changes: 1 addition & 1 deletion Unity-Package/Packages/manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"dependencies": {
"com.unity.ide.visualstudio": "2.0.26",
"com.unity.test-framework": "1.1.33",
"com.unity.textmeshpro": "3.0.6",
"com.unity.textmeshpro": "3.0.7",
"com.unity.ugui": "1.0.0",
"com.unity.modules.ai": "1.0.0",
"com.unity.modules.androidjni": "1.0.0",
Expand Down
13 changes: 1 addition & 12 deletions Unity-Package/Packages/packages-lock.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
"url": "https://packages.unity.com"
},
"com.unity.textmeshpro": {
"version": "3.0.6",
"version": "3.0.7",
"depth": 0,
"source": "registry",
"dependencies": {
Expand Down Expand Up @@ -177,17 +177,6 @@
"version": "1.0.0",
"depth": 0,
"source": "builtin",
"dependencies": {
"com.unity.modules.ui": "1.0.0",
"com.unity.modules.imgui": "1.0.0",
"com.unity.modules.jsonserialize": "1.0.0",
"com.unity.modules.uielementsnative": "1.0.0"
}
},
"com.unity.modules.uielementsnative": {
"version": "1.0.0",
"depth": 1,
"source": "builtin",
"dependencies": {
"com.unity.modules.ui": "1.0.0",
"com.unity.modules.imgui": "1.0.0",
Expand Down
5 changes: 4 additions & 1 deletion Unity-Package/ProjectSettings/EditorBuildSettings.asset
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,8 @@
EditorBuildSettings:
m_ObjectHideFlags: 0
serializedVersion: 2
m_Scenes: []
m_Scenes:
- enabled: 1
path: Assets/Sample/Sample Scene.unity
guid: 16f84dea0311eb541a18828842cec875
m_configObjects: {}
Loading
Loading