Replace int(int_value / int_value) with floordiv#132
Open
sterliakov wants to merge 1 commit intoJAMdotTech:masterfrom
Open
Replace int(int_value / int_value) with floordiv#132sterliakov wants to merge 1 commit intoJAMdotTech:masterfrom
int(int_value / int_value) with floordiv#132sterliakov wants to merge 1 commit intoJAMdotTech:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While it can not cause any loss of precision for numbers under
2**53, and all the affected cases do not deal with numbers larger than0xffffff, this is still a code smell (and is not obviously correct - usingint(value / 4)instead ofvalue // 4can cause loss of precision for e.g.value = 2**63 - 1, resulting in a number off by one. Using floordiv with Python integers (which do not have limited bitwidth) avoids such questions entirely.