add ice thickness test data#229
Merged
srherbener merged 4 commits intodevelopfrom Feb 6, 2026
Merged
Conversation
DJDavies2
reviewed
Jan 6, 2026
Contributor
DJDavies2
left a comment
DJDavies2
left a comment
There was a problem hiding this comment.
See comment in OPS ticket. In terms of getting it merged, many assigning someone like @srherbener as revewer?
twsearle
force-pushed
the
feature/ODB-read-iceThickness-iceFreeboard
branch
from
7c7cc16 to
c7431e6
Compare
twsearle
force-pushed
the
feature/ODB-read-iceThickness-iceFreeboard
branch
from
c7431e6 to
ec973f8
Compare
Contributor
|
An ioda test is currently failing with this: test_ioda-convert_stationsnow_statid_odc This is with ioda 1601. |
Contributor
Author
should be fixed now! thanks |
mo-RowanMcL
approved these changes
Feb 5, 2026
Contributor
mo-RowanMcL
left a comment
mo-RowanMcL
left a comment
There was a problem hiding this comment.
Looks good to me, and thanks for fixing the reference data for stationsnow.
DJDavies2
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add test data for reading ice thickness observations from ODB files.
Issue(s) addressed
following on from https://github.com/JCSDA-internal/ufo/issues/3770 as part of operational implementation of ice thickness at the Met Office.
Dependencies
build-group=https://github.com/JCSDA-internal/ioda/pull/1601
Checklist