Remove crtm-fix/crtm 2.3.0_emc; fix directory structure of crtm-fix files (create symbolic links for backward compatibility)#43
Open
climbfuji wants to merge 4 commits intoJCSDA:spack-stack-devfrom
Conversation
… remaining versions: retain original directory structure, link requested files to top-level 'fix' dir
11 tasks
…ages into bugfix/crtm_fix_link_instead_of_flatten
climbfuji
requested review from
ADCollard,
AlexanderRichert-NOAA,
BenjaminTJohnson,
DavidHuber-NOAA and
eap
climbfuji
commented
Mar 4, 2026
| ctest = Executable(self.spec["cmake"].prefix.bin.ctest) | ||
| with working_dir(self.build_directory): | ||
| ctest("--timeout", "120", "-R", "test_check_crtm") | ||
| ctest("--timeout", "120") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
For spack-stack-2.2.x (i.e. after creating release branch
release/2.1):crtm-fix@2.3.0_emcandcrtm@2.3.0_emc.crtm-fixfor all remaining versions: retain original directory structure, link requested files to top-levelfixdirectory.The resulting symbolic links are identical to the current files at the top-level
fixdirectory.Issues
Working toward JCSDA/spack-stack#1910 and JCSDA/spack-stack#1914
Testing
See JCSDA/spack-stack#1928
Upstream PR
Will be created after this PR is merged. There are already differences between the upstream crtm/crtm-fix code and our code, this PR just adds on to them.