Perf: Optimize string construction in _find_and_replace #27
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR optimizes
_find_and_replaceby replacing incremental string concatenation (wm_text += ...) with list accumulation and.join().The Issue: Using
+=inside the loop forces quadratic time complexityO(N^2)for string construction because Python creates a new string object for every iteration.The Solution: I refactored the code to accumulate segments in a list (
wm_parts) and join them once at the end. This ensures linear time complexityO(N)for memory allocation without altering the underlying search logic.This is in line with standard python performance recommendation: https://peps.python.org/pep-0008/#programming-recommendations